Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 77693
Status: open
Priority: 0/
Queue: Perl-Critic
People
Owner: Nobody in particular
Requestors: intrigeri [...] debian.org
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Thu Jun 07 18:22:06 2012 intrigeri [...] debian.org - Ticket created
Subject: [PATCH] Stop using obsolete make-local-hook function
Date: Fri, 8 Jun 2012 00:20:03 +0200
To: bug-perl-critic [...] rt.cpan.org
From: intrigeri <intrigeri [...] debian.org>
In Debian we are currently applying the attached patch to Perl-Critic. We thought you might be interested in it, too. From: intrigeri <intrigeri@boum.org> Date: Thu, 7 Jun 2012 23:17:51 +0200 Subject: Don't use obsolete make-local-hook function. Instead, pass a non-nil value to the `LOCAL' argument of add-hook, which has been nicely replacing the need to run make-local-hook since Emacs 21.1. --- extras/perlcritic.el | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/extras/perlcritic.el b/extras/perlcritic.el index e1b74a7..570b9c7 100644 Thanks in advance, intrigeri, Debian Perl Group

Message body is not shown because sender requested not to inline it.

  Fri Jun 08 16:40:38 2012 jeff [...] imaginative-software.com - Correspondence added
Subject: Re: [rt.cpan.org #77693] [PATCH] Stop using obsolete make-local-hook function
Date: Fri, 8 Jun 2012 13:40:22 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
Thanks! Is there any harm in doing it the old way (for the sake of compatibility)? Not saying I won't change it -- just asking. -Jeff
  Fri Jun 08 16:40:39 2012 The RT System itself - Status changed from 'new' to 'open'
  Fri Jun 08 16:49:47 2012 intrigeri [...] debian.org - Correspondence added
Subject: Re: [rt.cpan.org #77693] [PATCH] Stop using obsolete make-local-hook function
Date: Fri, 08 Jun 2012 22:49:09 +0200
To: bug-Perl-Critic [...] rt.cpan.org
From: intrigeri <intrigeri [...] debian.org>
Jeffrey Thalhammer via RT wrote (08 Jun 2012 20:40:39 GMT) : Show quoted text
> Thanks! Is there any harm in doing it the old way (for the sake of > compatibility)?
There is: Emacs 24 does not have the old function anymore. The old function has been deprecated since Emacs 21.1, that was released October 20, 2001. I think it's better to support Emacs 24 than Emacs 21.1.
  Fri Jun 08 16:53:12 2012 jeff [...] imaginative-software.com - Correspondence added
Subject: Re: [rt.cpan.org #77693] [PATCH] Stop using obsolete make-local-hook function
Date: Fri, 8 Jun 2012 13:53:01 -0700
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
On Jun 8, 2012, at 1:49 PM, intrigeri via RT wrote: Show quoted text
> The old function has been deprecated since Emacs 21.1, > that was released October 20, 2001. > > I think it's better to support Emacs 24 than Emacs 21.1.
Good enough for me. Thanks! -Jeff