Skip Menu |

This queue is for tickets about the Sys-Info-Driver-Linux CPAN distribution.

Report information
The Basics
Id: 77563
Status: resolved
Priority: 0/
Queue: Sys-Info-Driver-Linux

People
Owner: Nobody in particular
Requestors: me [...] eboxr.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.7900
Fixed in: (no value)



Subject: Centos Configuration release
The centos config need to be adjusted like this for centos 6, as the redhat-release is a link. We need to use the centos-release version. Removing the redhat-release, should also solve the case 72673 UNAME: Linux rpmb-32-centos-6 2.6.32-220.7.1.el6.i686 #1 SMP Tue Mar 6 21:21:22 GMT 2012 i686 i686 i386 GNU/Linux ll /etc/*release -rw-r--r--. 1 root root 27 Dec 8 21:03 /etc/centos-release lrwxrwxrwx. 1 root root 14 Jan 31 15:48 /etc/redhat-release -> centos-release lrwxrwxrwx. 1 root root 14 Jan 31 15:48 /etc/system-release -> centos-release --- lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm +++ lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm @@ -22,6 +22,7 @@ $VERSION = '0.7900'; <centos> manufacturer = Lance Davis - release = redhat-release + release = centos-release version_match = CentOS(?: Linux)? release (.*) \( </centos>
Here is the patch for the redhat enterprise that also need to be added diff --git lib/Sys/Info/Driver/Linux/OS/Distribution.pm lib/Sys/Info/Driver/Linux/OS/Distribution.pm index 3796173..dabbaa1 100644 --- lib/Sys/Info/Driver/Linux/OS/Distribution.pm +++ lib/Sys/Info/Driver/Linux/OS/Distribution.pm @@ -86,6 +86,7 @@ sub _probe_release { if ( -f "/etc/$id" && !-l "/etc/$id" ){ $self->{DISTRIB_ID} = $r->{ $id }; $self->{release_file} = $id; + next unless $self->{DISTRIB_ID} && $self->_probe_version; return $self->{DISTRIB_ID}; } } diff --git lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm index fcc3515..2fb683e 100644 --- lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm +++ lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm @@ -154,9 +154,10 @@ $VERSION = '0.7900'; </redflag> <redhat> - version_match = Red Hat Linux release (.*) \( + version_match = Red Hat (?:Enterprise )?Linux (?:Server )release (.*) \( release = redhat-release release = redhat_version + release_derived = redhat-release </redhat> <pardus> On Thu May 31 13:21:48 2012, atoomic wrote: Show quoted text
> The centos config need to be adjusted like this for centos 6, as the > redhat-release is a link. > We need to use the centos-release version. > Removing the redhat-release, should also solve the case 72673 > > UNAME: Linux rpmb-32-centos-6 2.6.32-220.7.1.el6.i686 #1 SMP Tue Mar 6 > 21:21:22 GMT > 2012 i686 i686 i386 GNU/Linux > > ll /etc/*release > -rw-r--r--. 1 root root 27 Dec 8 21:03 /etc/centos-release > lrwxrwxrwx. 1 root root 14 Jan 31 15:48 /etc/redhat-release -> centos- > release > lrwxrwxrwx. 1 root root 14 Jan 31 15:48 /etc/system-release -> centos- > release > > --- lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm > +++ lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm > @@ -22,6 +22,7 @@ $VERSION = '0.7900'; > <centos> > manufacturer = Lance Davis > - release = redhat-release > + release = centos-release > version_match = CentOS(?: Linux)? release (.*) \( > </centos>
in the first patch we did not need to remove the release = redhat-release On Thu May 31 13:21:48 2012, atoomic wrote: Show quoted text
> The centos config need to be adjusted like this for centos 6, as the > redhat-release is a link. > We need to use the centos-release version. > Removing the redhat-release, should also solve the case 72673 > > UNAME: Linux rpmb-32-centos-6 2.6.32-220.7.1.el6.i686 #1 SMP Tue Mar 6 > 21:21:22 GMT > 2012 i686 i686 i386 GNU/Linux > > ll /etc/*release > -rw-r--r--. 1 root root 27 Dec 8 21:03 /etc/centos-release > lrwxrwxrwx. 1 root root 14 Jan 31 15:48 /etc/redhat-release -> centos- > release > lrwxrwxrwx. 1 root root 14 Jan 31 15:48 /etc/system-release -> centos- > release > > --- lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm > +++ lib/Sys/Info/Driver/Linux/OS/Distribution/Conf.pm > @@ -22,6 +22,7 @@ $VERSION = '0.7900'; > <centos> > manufacturer = Lance Davis > - release = redhat-release > + release = centos-release > version_match = CentOS(?: Linux)? release (.*) \( > </centos>
Hi, This is fixed in v0.7901 (will arrive into CPAN mirrors shortly). -Burak