Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Pod-Simple CPAN distribution.

Report information
The Basics
Id: 77419
Status: resolved
Priority: 0/
Queue: Pod-Simple

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc: grantm [...] cpan.org
AdminCc:

Bug Information
Severity: Normal
Broken in: 3.21
Fixed in: 3.22



Subject: 3.21 breaks test in ENELL/WWW-Translate-Apertium-0.16.tar.gz
Please visit https://rt.cpan.org/Ticket/Display.html?id=77418 The ticket describes a CPAN distro that fails since the release of 3.21 if Test::Pod is installed. Thanks,
On 2012-05-25 01:06:34, ANDK wrote: Show quoted text
> Please visit https://rt.cpan.org/Ticket/Display.html?id=77418 > > The ticket describes a CPAN distro that fails since the release of 3.21 > if Test::Pod is installed. > > Thanks,
This is actually a new feature in 3.21, to help folks identify encoding issues in their Pod. From the Changes: Now emit a warning the first time a non-ASCII byte is encountered when no "=encoding" has been seen. Grant McLean. So folks who get this warning now have an opportunity to fix an encoding issue in their Pod.
On Fri May 25 12:06:53 2012, DWHEELER wrote: Show quoted text
> On 2012-05-25 01:06:34, ANDK wrote:
> > Please visit https://rt.cpan.org/Ticket/Display.html?id=77418 > > > > The ticket describes a CPAN distro that fails since the release of
> 3.21
> > if Test::Pod is installed. > > > > Thanks,
> > This is actually a new feature in 3.21, to help folks identify > encoding issues in their Pod. From > the Changes: > > Now emit a warning the first time a non-ASCII byte is encountered > when no "=encoding" has been seen. Grant McLean. > > So folks who get this warning now have an opportunity to fix an > encoding issue in their Pod.
But it shouldn’t be trying to validate the encoding outside of POD blocks. See <http://www.cpantesters.org/cpan/report/e0d0f850-a504-11e1-a462- Show quoted text
34fdf3b14d39>.
Subject: Re: [rt.cpan.org #77419] 3.21 breaks test in ENELL/WWW-Translate-Apertium-0.16.tar.gz
Date: Fri, 25 May 2012 09:34:57 -0700
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On May 25, 2012, at 9:25 AM, Father Chrysostomos via RT wrote: Show quoted text
> But it shouldn’t be trying to validate the encoding outside of POD blocks. > > See <http://www.cpantesters.org/cpan/report/e0d0f850-a504-11e1-a462-
> 34fdf3b14d39>.
Ah, quite right. Here is the offending line in DBM::Deep: https://metacpan.org/source/SPROUT/DBM-Deep-2.0006/lib/DBM/Deep.pm#L669 Grant, can you look into this, please? Thanks, David
Subject: Re: [rt.cpan.org #77419] 3.21 breaks test in ENELL/WWW-Translate-Apertium-0.16.tar.gz
Date: Sat, 26 May 2012 07:13:24 +1200
To: bug-Pod-Simple [...] rt.cpan.org
From: Grant McLean <grant [...] mclean.net.nz>
On Fri, 2012-05-25 at 12:35 -0400, David Wheeler via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=77419 > > > On May 25, 2012, at 9:25 AM, Father Chrysostomos via RT wrote: >
> > But it shouldn’t be trying to validate the encoding outside of POD blocks. > > > > See <http://www.cpantesters.org/cpan/report/e0d0f850-a504-11e1-a462-
> > 34fdf3b14d39>.
> > Ah, quite right. Here is the offending line in DBM::Deep: > > https://metacpan.org/source/SPROUT/DBM-Deep-2.0006/lib/DBM/Deep.pm#L669 > > Grant, can you look into this, please?
Will do. Regards Grant
CC: ANDK [...] cpan.org, grantm [...] cpan.org
Subject: Re: [rt.cpan.org #77419] 3.21 breaks test in ENELL/WWW-Translate-Apertium-0.16.tar.gz
Date: Sat, 26 May 2012 15:15:24 +1200
To: bug-Pod-Simple [...] rt.cpan.org
From: Grant McLean <grant [...] mclean.net.nz>
On Fri, 2012-05-25 at 12:35 -0400, David Wheeler via RT wrote: Show quoted text
> Grant, can you look into this, please?
This pull request should ensure that the encoding heuristic and warning is only applied to POD lines: https://github.com/theory/pod-simple/pull/29 Thanks for the report. Regards Grant
On Fri May 25 23:15:44 2012, grant@mclean.net.nz wrote: Show quoted text
> On Fri, 2012-05-25 at 12:35 -0400, David Wheeler via RT wrote:
> > Grant, can you look into this, please?
> > This pull request should ensure that the encoding heuristic and warning > is only applied to POD lines: > > https://github.com/theory/pod-simple/pull/29
Thank you. Will this be fixed in 3.22? I’m going to add a skip to DBM::Deep’s test suite conditional on the Pod::Simple version, and it would be nice to know ahead of time.
Subject: Re: [rt.cpan.org #77419] 3.21 breaks test in ENELL/WWW-Translate-Apertium-0.16.tar.gz
Date: Sun, 27 May 2012 11:22:10 -0700
To: bug-Pod-Simple [...] rt.cpan.org
From: "David E. Wheeler" <dwheeler [...] cpan.org>
On May 25, 2012, at 10:23 PM, Father Chrysostomos via RT wrote: Show quoted text
> Thank you. Will this be fixed in 3.22?
Yes, just uploaded it. Show quoted text
> I’m going to add a skip to DBM::Deep’s test suite conditional on the Pod::Simple version, and it > would be nice to know ahead of time.
Sorry about that hassle. David
On Sun May 27 16:16:11 2012, DWHEELER wrote: Show quoted text
> On May 25, 2012, at 10:23 PM, Father Chrysostomos via RT wrote: >
> > Thank you. Will this be fixed in 3.22?
> > Yes, just uploaded it.
Thank you. Show quoted text
> > I’m going to add a skip to DBM::Deep’s test suite conditional on the
> Pod::Simple version, and it
> > would be nice to know ahead of time.
> > Sorry about that hassle.
No problem at all.