Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CPAN-Mini CPAN distribution.

Report information
The Basics
Id: 7737
Status: resolved
Worked: 1 hour (60 min)
Priority: 0/
Queue: CPAN-Mini

People
Owner: rjbs [...] cpan.org
Requestors: mark [...] twoshortplanks.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.18
Fixed in: (no value)

Attachments


Subject: Deletes .DS_Store files during mirroring
The CPAN mirror script deletes .DS_Store files that MacOS uses to keep Finder information in (e.g. the x,y coords of the file in the finder display.) Attached is a patch that prevents the mirroring from incorrectly deleting these files. (This problem is on stock perl (5.8.1-RC3) on Mac OS X 10.3.something_or_other)
Only in CPAN-Mini-mark: Makefile Only in CPAN-Mini-mark: blib diff -ur CPAN-Mini-0.16/lib/CPAN/Mini.pm CPAN-Mini-mark/lib/CPAN/Mini.pm --- CPAN-Mini-0.16/lib/CPAN/Mini.pm Wed Sep 8 02:46:27 2004 +++ CPAN-Mini-mark/lib/CPAN/Mini.pm Wed Sep 22 11:45:33 2004 @@ -190,11 +190,17 @@ =cut +# files that are allowed to remain in the mirror +our %allowed_files = map { $_ => 1 } ( + ".DS_Store", +); + sub clean_unmirrored { my $self = shift; find sub { return unless -f and not $self->{mirrored}{$File::Find::name}; + return if $allowed_files{$_}; $self->trace("$File::Find::name ... removed\n"); unlink $_ or warn "Cannot remove $File::Find::name: $!"; }, $self->{local}; Only in CPAN-Mini-mark: pm_to_blib
Date: Wed, 22 Sep 2004 07:47:34 -0400
From: Ricardo SIGNES <rjbs [...] cpan.org>
To: Guest via RT <bug-CPAN-Mini [...] rt.cpan.org>
Subject: Re: [cpan #7737] Deletes .DS_Store files during mirroring
RT-Send-Cc:
* Guest via RT <bug-CPAN-Mini@rt.cpan.org> [2004-09-22T06:51:24] Show quoted text
> The CPAN mirror script deletes .DS_Store files [...]
It's easy enough to fix this problem, so I will, but just out of curiousity: has this had any practical effect on you? I'm just surprised anyone would be setting any metadata on those files. ;) -- rjbs
Download (untitled)
application/pgp-signature 189b

Message body not shown because it is not plain text.