Bug #77357 for Moose: Attribute named "new" breaks weirdly

Tue May 22 06:22:39 2012 rt.cpan [...] sartak.org - Ticket created

Subject:

Attribute named "new" breaks weirdly

package Change; use Moose; has old => (is => 'ro'); has new => (is => 'ro'); package main; my $change = Change->new( old => 'Dave', new => 'Stevan', ); print $change->old . ' -> ' . $change->new; The error you get is in the call to Change->new, which is the accessor you declared. Should we warn about accessors named "new"?

Sat May 26 17:58:16 2012 DROLSKY [...] cpan.org - Correspondence added

On Tue May 22 06:22:39 2012, SARTAK wrote: Show quoted text

> package Change; > use Moose; > > has old => (is => 'ro'); > has new => (is => 'ro'); > > package main; > my $change = Change->new( > old => 'Dave', > new => 'Stevan', > ); > > print $change->old . ' -> ' . $change->new; > > > The error you get is in the call to Change->new, which is the accessor > you declared. > > Should we warn about accessors named "new"?

In theory you can change what the constructor is named. This is easily done by passing an argument to make_immutable, although for non- immutable classes you'd have to write a shim that called SUPER::new or something bizarre like that. That all said, the most common case is that the constructor is called "new". So maybe we should warn by default but provide some way to suppress the warning for people who really really want an attribute named new?

Sat May 26 17:58:18 2012 The RT System itself - Status changed from 'new' to 'open'

Wed Nov 22 14:33:12 2017 LANCEW [...] cpan.org - Correspondence added

We tried to replicate this issue with a file containing: --- package Change; use Moose; has old => (is => 'ro'); has new => (is => 'ro'); package main; my $change = Change->new( old => 'Dave', new => 'Stevan', ); print $change->old . ' -> ' . $change->new; --- This generates the following error: Cannot assign a value to a read-only accessor at reader Change::new (defined at Change.pl line 5) line 3 Change::new('Change', 'old', 'Dave', 'new', 'Stevan') called at Change.pl line 9 --- So does this suggest that this issue can be closed?

Wed Nov 22 14:34:58 2017 DROLSKY [...] cpan.org - Correspondence added

On 2017-11-22 13:33:12, LANCEW wrote: Show quoted text

> We tried to replicate this issue with a file containing: > > --- > > package Change; > use Moose; > > has old => (is => 'ro'); > has new => (is => 'ro'); > > package main; > > my $change = Change->new( old => 'Dave', new => 'Stevan', ); > > print $change->old . ' -> ' . $change->new; > > --- > > This generates the following error: > > Cannot assign a value to a read-only accessor at reader Change::new > (defined at Change.pl line 5) line 3 > Change::new('Change', 'old', 'Dave', 'new', 'Stevan') called > at Change.pl line 9 > > --- > > So does this suggest that this issue can be closed?

No, this is the same issue, I think. The attribute accessor has overridden the constructor so now this class effectively has no constructor.