Skip Menu |

This queue is for tickets about the Net-DNS CPAN distribution.

Report information
The Basics
Id: 77304
Status: resolved
Priority: 0/
Queue: Net-DNS

People
Owner: Nobody in particular
Requestors: TINITA [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: Warning in Net::DNS::Resolver::Win32
Hi, I have module (Parse::BBCode) which uses Email::Valid in a test, which uses Net::DNS. I'm testing for no warnings with Test::NoWarnings and got some FAIL reports for windows. I haven't got windows here so I can't reproduce and also don't know the module version. Here are the reports: http://www.cpantesters.org/cpan/report/ dba377fd-8c60-1017-96e7-7c9b05085451 http://www.cpantesters.org/cpan/ report/6ff889b9-8ad0-1016-91ec-5ca205085451 http://www.cpantesters.org/cpan/ report/786e6e09-974d-1016-809a-689b05085451 Could you have a look if it's possible to avoid the warning? thanks, tina
Hi Tina, I wasn't able to reproduce, but it is quiet obvious what went wrong and how to fix it. Thanks for reporting! -- Willem The fix: Index: lib/Net/DNS/Resolver/Win32.pm =================================================================== --- lib/Net/DNS/Resolver/Win32.pm (revision 995) +++ lib/Net/DNS/Resolver/Win32.pm (working copy) @@ -76,7 +76,7 @@ if (defined $reg_tcpip){ $searchlist .= "," if $searchlist; # $domain already in there - $searchlist .= $reg_tcpip->GetValue('SearchList'); + $searchlist .= ($reg_tcpip->GetValue('SearchList') || ""); my ($value, $type) = $reg_tcpip->GetValue('UseDomainNameDevolution'); $usedevolution = defined $value && $type == REG_DWORD ? hex $value : 0; } On Sat 19 Mei 2012 17:55:00, TINITA wrote: Show quoted text
> Hi, > > I have module (Parse::BBCode) which uses Email::Valid in a test, which > uses Net::DNS. > I'm testing for no warnings with Test::NoWarnings and got some FAIL > reports for windows. I haven't got windows here so I can't reproduce > and also don't know the module version. > > Here are the reports: > http://www.cpantesters.org/cpan/report/ > dba377fd-8c60-1017-96e7-7c9b05085451 > http://www.cpantesters.org/cpan/ > report/6ff889b9-8ad0-1016-91ec-5ca205085451 > http://www.cpantesters.org/cpan/ > report/786e6e09-974d-1016-809a-689b05085451 > > Could you have a look if it's possible to avoid the warning? > > thanks, > tina