Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the CPAN-Meta CPAN distribution.

Report information
The Basics
Id: 77296
Status: resolved
Priority: 0/
Queue: CPAN-Meta

People
Owner: Nobody in particular
Requestors: thaljef [...] cpan.org
Cc: h.m.brand [...] xs4all.nl
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



CC: h.m.brand [...] xs4all.nl
Subject: Documentation for meta-spec version is confusing
The documentation says this about the "version" subkey of the meta-spec key: This subkey gives the integer Version of the CPAN Meta Spec against which the document was generated. That doesn't look right to me. First, the Version type is defined as things that version.pm can parse. That implies that the meta-spec version could be 2 or 2.1 or 2.1.1. Second, the current version is "2", but earlier versions have been "1.4", "1.3", and so on. Third, the default value if you do not specify a meta-spec version is "1.0". So the meta-spec version can't be limited to integers, as the docs suggest. But my real dillemma is this: https://metacpan.org/source/HMBRAND/DBD-CSV-0.34/META.json In that file, the meta-spec version is "2.0" not "2". CPAN::Meta::Validator won't accept that because it doesn't match the keys of any of its %definitions. I think the meta-spec version needs to be normalized and stringified with version.pm before looking it up in the %definitions. But the choice of "2" for the current version seems very deliberate, so perhaps I'm missing something here. Thanks for your time. -Jeff
On Fri May 18 19:13:12 2012, THALJEF wrote: Show quoted text
> This subkey gives the integer Version of the CPAN Meta Spec against > which the document was generated.
That's the definition as of version 2 of the spec. Earlier versions didn't specify, so they can have non-integer versions. That's done intentionally so that CPAN::Meta $VERSION integer component corresponds to the spec number and the "decimal" part of the $VERSION is just a release sequence. (Without getting into dotted decimal.) Show quoted text
I suspect Tux is hand-generating his metadata and didn't realize it has to be an integer. David
CC: thaljef [...] cpan.org, h.m.brand [...] xs4all.nl
Subject: Re: [rt.cpan.org #77296] Documentation for meta-spec version is confusing
Date: Fri, 18 May 2012 17:16:39 -0700
To: bug-CPAN-Meta [...] rt.cpan.org
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
On May 18, 2012, at 4:52 PM, David Golden via RT wrote: Show quoted text
> That's done > intentionally so that CPAN::Meta $VERSION integer component corresponds > to the spec number and the "decimal" part of the $VERSION is just a > release sequence. (Without getting into dotted decimal.)
Ok. I figured there might be a reason it was just "2". Thanks for clarifying. Show quoted text
> I suspect Tux is hand-generating his metadata and didn't realize it has > to be an integer.
Tux - I'd send you a patch, but it looks like you've got your own tools for generating your META. -Jeff
Subject: Re: [rt.cpan.org #77296] Documentation for meta-spec version is confusing
Date: Sat, 19 May 2012 08:12:21 +0200
To: bug-CPAN-Meta [...] rt.cpan.org, thaljef [...] cpan.org, David Golden <xdaveg [...] gmail.com>
From: "H.Merijn Brand" <h.m.brand [...] xs4all.nl>
On Fri, 18 May 2012 20:16:52 -0400, "Jeffrey Thalhammer via RT" <bug-CPAN-Meta@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=77296 > > > > On May 18, 2012, at 4:52 PM, David Golden via RT wrote: >
> > That's done > > intentionally so that CPAN::Meta $VERSION integer component corresponds > > to the spec number and the "decimal" part of the $VERSION is just a > > release sequence. (Without getting into dotted decimal.)
> > Ok. I figured there might be a reason it was just "2". Thanks for clarifying. >
> > I suspect Tux is hand-generating his metadata and didn't realize it has > > to be an integer.
> > Tux - I'd send you a patch, but it looks like you've got your own tools for > generating your META.
Patch against these two, and I'll change all my modules: http://repo.or.cz/w/DBD-CSV.git/blob/HEAD:/sandbox/genMETA.pl http://repo.or.cz/w/DBD-CSV.git/blob/HEAD:/sandbox/genMETA.pm Main reason for doing it like this is Spreadsheet::Read, where optional parts were impossible to do right from the build tools http://repo.or.cz/w/Spreadsheet-Read.git/blob/HEAD:/sandbox/genMETA.pl If you patch the .pm, all my modules will take advantage, as it is shared. Main reason there is to add all possible checks. Show quoted text
> -Jeff
-- H.Merijn Brand http://tux.nl Perl Monger http://amsterdam.pm.org/ using perl5.00307 .. 5.14 porting perl5 on HP-UX, AIX, and openSUSE http://mirrors.develooper.com/hpux/ http://www.test-smoke.org/ http://qa.perl.org http://www.goldmark.org/jeff/stupid-disclaimers/
I'm going to assume Tux has fixed this in his code and will close the ticket.