Bug #77253 for syntax: no syntax qw( module );

Wed May 16 20:40:59 2012 IKEGAMI [...] cpan.org - Ticket created

Subject:

no syntax qw( module );

Hi, It was suggested that I move some of my modules to Syntax::Feature::. My modules currently support C<< no module; >>, but L<syntax> does not forward C<unimport> to modules in the same way as it forwards C<import>. Would you be amiable to adding this feature? I can create a patch for you. The core of it would be: return if !$package->can('uninstall'); return $package->uninstall( from => $caller, options => $options, identifier => $feature, outer => $all_params, ); Thanks, Eric

Thu May 17 12:33:43 2012 IKEGAMI [...] cpan.org - Dependency by ticket #77250 added

Fri May 18 11:06:03 2012 rs [...] 474.at - Correspondence added

Subject:	Re: [rt.cpan.org #77253] no syntax qw( module );
Date:	Fri, 18 May 2012 17:05:47 +0200
To:	bug-syntax [...] rt.cpan.org
From:	Robert Sedlacek <rs [...] 474.at>

Hi Eric, First, sorry it took me a couple days to reply. On Wed, 2012-05-16 at 20:41 -0400, ikegami via RT wrote: Show quoted text

> It was suggested that I move some of my modules to Syntax::Feature::. > > My modules currently support C<< no module; >>, but L<syntax> does not > forward C<unimport> to modules in the same way as it forwards C<import>. > > Would you be amiable to adding this feature? I can create a patch for > you. The core of it would be: > > return if !$package->can('uninstall'); > return $package->uninstall( > from => $caller, > options => $options, > identifier => $feature, > outer => $all_params, > );

I've added a first draft of the feature to the repository at https://github.com/phaylon/syntax It currently warns if you try to `no syntax 'foo'` when 'foo' doesn't provide an uninstall method. I thought simply not doing anything might be surprising. But I'm not too fixated on that if you have a need for it to be a NOOP. If this does what you require, I'd be happy to push a release. HTH, Robert

Fri May 18 11:06:04 2012 The RT System itself - Status changed from 'new' to 'open'

Fri May 18 12:13:01 2012 ikegami [...] adaelis.com - Correspondence added

CC:	IKEGAMI [...] cpan.org
Subject:	Re: [rt.cpan.org #77253] no syntax qw( module );
Date:	Fri, 18 May 2012 12:12:51 -0400
To:	bug-syntax [...] rt.cpan.org
From:	Eric Brine <ikegami [...] adaelis.com>

On Fri, May 18, 2012 at 11:06 AM, Robert 'phaylon' Sedlacek via RT < bug-syntax@rt.cpan.org> wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=77253 > > I thought simply not doing anything might > be surprising. But I'm not too fixated on that

if you have a need for it to be a NOOP. Show quoted text

>

I simply did it that way because that's how modules without unimport behave. $ perl -e'no CGI;' $ perl -e'no DBI;' $ perl -e'BEGIN { $INC{"Foo.pm"} = 1; } no Foo;' $ That said, I see no harm in issuing a warning or even croaking. If this does what you require, I'd be happy to push a release. Show quoted text

>

Looks good, except $package->uninstall( into => ... ) doesn't make that much sense, grammatically speaking. Perhaps the following would be better? $package->uninstall( from => ... ) Thanks! - Eric

Fri May 18 13:34:01 2012 ikegami [...] adaelis.com - Correspondence added

CC:	IKEGAMI [...] cpan.org
Subject:	Re: [rt.cpan.org #77253] no syntax qw( module );
Date:	Fri, 18 May 2012 13:33:49 -0400
To:	bug-syntax [...] rt.cpan.org
From:	Eric Brine <ikegami [...] adaelis.com>

On Fri, May 18, 2012 at 12:13 PM, ikegami@adaelis.com via RT < bug-syntax@rt.cpan.org> wrote: Show quoted text

> Looks good, except > > $package->uninstall( into => ... ) > > doesn't make that much sense, grammatically speaking. Perhaps the following > would be better? > > $package->uninstall( from => ... ) >

Patch provided: https://github.com/phaylon/syntax/pull/1

Fri May 18 14:51:18 2012 rs [...] 474.at - Correspondence added

Subject:	Re: [rt.cpan.org #77253] no syntax qw( module );
Date:	Fri, 18 May 2012 20:51:06 +0200
To:	bug-syntax [...] rt.cpan.org
From:	Robert Sedlacek <rs [...] 474.at>

On Fri, 2012-05-18 at 13:34 -0400, ikegami@adaelis.com via RT wrote: Show quoted text

> > Looks good, except > > > > $package->uninstall( into => ... ) > > > > doesn't make that much sense, grammatically speaking. Perhaps the following > > would be better? > > > > $package->uninstall( from => ... ) > >

> > Patch provided: > https://github.com/phaylon/syntax/pull/1

Yea, the consistency-keeping side of my brain won over the English speaking one there. Pulled and released: https://metacpan.org/release/PHAYLON/syntax-0.004 Thanks! Robert

Fri May 18 14:53:37 2012 rs [...] 474.at - Status changed from 'open' to 'resolved'