Bug #77216 for SQL-Bibliosoph: INSERT doesn't return last_insert

Tue May 15 07:26:42 2012 JKRAMER [...] cpan.org - Ticket created

INSERTs don't return the last_insert_id for PostgreSQL (or probably anything else but MySQL). Looks like the value is hardcoded to a MySQL-specific key, when it should use DBI->last_insert_id to be portable.

Tue May 15 09:18:06 2012 JKRAMER [...] cpan.org - Subject changed from (no value) to 'INSERT doesn't return last_insert_id'

Tue May 15 13:12:03 2012 matiu [...] cpan.org - Correspondence added

On Tue May 15 07:26:42 2012, jkramer wrote: Show quoted text

> INSERTs don't return the last_insert_id for PostgreSQL (or probably > anything else but MySQL). Looks like the value is hardcoded to a > MySQL-specific key, when it should use DBI->last_insert_id to be portable.

Thanks. I will fixit this week.

Tue May 15 13:12:05 2012 The RT System itself - Status changed from 'new' to 'open'

Tue May 15 14:20:27 2012 matiu [...] cpan.org - Correspondence added

Since DBI's last_insert_id has very different behaviors depending the driver, I add this to the documentation: Note that $last_insert_id is only returned when using MYSQL (undef in other case). When using other engine you need to call an other query to get the last value. For example, in ProgreSQL you can define: --[ LAST_VAL ] SELECT lastval() and then call LAST_VAL after an insert. ok? thanks. On Tue May 15 13:12:03 2012, MATIU wrote: Show quoted text

> On Tue May 15 07:26:42 2012, jkramer wrote:

> > INSERTs don't return the last_insert_id for PostgreSQL (or probably > > anything else but MySQL). Looks like the value is hardcoded to a > > MySQL-specific key, when it should use DBI->last_insert_id to be portable.

> > Thanks. I will fixit this week.

Tue May 15 14:20:28 2012 matiu [...] cpan.org - Status changed from 'open' to 'resolved'

Wed May 16 06:43:12 2012 JKRAMER [...] cpan.org - Correspondence added

Instead of always returning undef, it would be helpful to return a value that at least indicates whether the INSERT succeeded or not. Even better would be to somehow make the value configurable for the user, maybe using an anonymous function, so I could for example override the default behavior by giving 'insert_return => sub { return $_[0]->dbh->last_insert_id }' or something like that to the constructor. On Tue May 15 14:20:27 2012, MATIU wrote: Show quoted text

> Since DBI's last_insert_id has very different behaviors depending the > driver, I add this to the > documentation: > > Note that $last_insert_id is only returned when using MYSQL (undef > in other case). > When using other engine you need to call an other query to get the > last value. > For example, in ProgreSQL you can define: > > --[ LAST_VAL ] > SELECT lastval() > > and then call LAST_VAL after an insert. > > ok? > > thanks. > > > On Tue May 15 13:12:03 2012, MATIU wrote:

> > On Tue May 15 07:26:42 2012, jkramer wrote:

> > > INSERTs don't return the last_insert_id for PostgreSQL (or

> probably

> > > anything else but MySQL). Looks like the value is hardcoded to a > > > MySQL-specific key, when it should use DBI->last_insert_id to be

> portable.

> > > > Thanks. I will fixit this week.

>

Wed May 16 06:43:13 2012 The RT System itself - Status changed from 'resolved' to 'open'

Wed May 16 07:50:25 2012 matiu [...] cpan.org - Correspondence added

On Wed May 16 06:43:12 2012, jkramer wrote: Show quoted text

> Instead of always returning undef, it would be helpful to return a value > that at least indicates whether the INSERT succeeded or not. Even better > would be to somehow make the value configurable for the user, maybe > using an anonymous function, so I could for example override the default > behavior by giving 'insert_return => sub { return > $_[0]->dbh->last_insert_id }' or something like that to the constructor.

thanks again! It actually returns 'undef' in case of success ( $stm->rows() != 0), and 0 in case of error (I know...). The customizable return value sounds ok. The insert_return function will receive the statement return, and the default insert_return will be: // sub insert_return { my ($selt, $statement) = @_; return 0 if ($statement->rows() || 0) == -1; return wantarray ? ($statement->{mysql_insertid}, $statement->rows() ) : $statement->{mysql_insertid} ; } // Does it make sense to you?

Bug #77216 for SQL-Bibliosoph: INSERT doesn't return last_insert_id