Skip Menu |

This queue is for tickets about the HTTP-Async CPAN distribution.

Report information
The Basics
Id: 77200
Status: resolved
Priority: 0/
Queue: HTTP-Async

People
Owner: Nobody in particular
Requestors: IKEGAMI [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Wishlist
Broken in: (no value)
Fixed in: (no value)



Subject: Feature request: remove() and remove_all()
Could you please add the following two function? sub remove { my ($self, $id) = @_; my $hashref = $self->{in_progress}{$id} or return undef; my $s = $hashref->{handle}; $self->_io_select->remove($s); delete $self->{fileno_to_id}{ $s->fileno }; delete $self->{in_progress}{$id}; delete $self->{id_opts}{$id}; return $hashref->{request}; } sub remove_all { my ($self) = @_; return map $self->remove($_), keys %{ $self->{in_progress} }; } Context: http://stackoverflow.com/questions/10587962/
The code is not quite right. It should remove requests in to_send and to_return too.
Subject: Re: [rt.cpan.org #77200] Feature request: remove() and remove_all()
Date: Tue, 15 May 2012 11:01:24 +0100
To: bug-HTTP-Async [...] rt.cpan.org
From: Edmund von der Burg <evdb [...] ecclestoad.co.uk>
On 14 May 2012 19:48, ikegami via RT <bug-HTTP-Async@rt.cpan.org> wrote: Show quoted text
>       Queue: HTTP-Async >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77200 > > > The code is not quite right. It should remove requests in to_send and > to_return too.
Could I ask you to do a fork and then submit a pull request on GitHub - it really is the easiest way to do this sort of thing. I'm not an active user of this module anymore - if you'd like to take over maintainer-ship that is also an option :) Cheers, Edmund.
CC: IKEGAMI [...] cpan.org
Subject: Re: [rt.cpan.org #77200] Feature request: remove() and remove_all()
Date: Wed, 16 May 2012 11:25:45 -0400
To: bug-HTTP-Async [...] rt.cpan.org
From: Eric Brine <ikegami [...] adaelis.com>
On Tue, May 15, 2012 at 6:01 AM, evdb@ecclestoad.co.uk via RT < bug-HTTP-Async@rt.cpan.org> wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=77200 > > > On 14 May 2012 19:48, ikegami via RT <bug-HTTP-Async@rt.cpan.org> wrote:
> > Queue: HTTP-Async > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77200 > > > > > The code is not quite right. It should remove requests in to_send and > > to_return too.
> > Could I ask you to do a fork and then submit a pull request on GitHub > - it really is the easiest way to do this sort of thing. > > I'm not an active user of this module anymore - if you'd like to take > over maintainer-ship that is also an option :) > > Cheers, > Edmund. >
I'll see what I can squeeze in. I've never used the module. (We use Net::Curl.)
This is up on Github: https://github.com/evdb/HTTP-Async/commit/315ef447721a9df043b63e4879f04a452e2a2646 https://github.com/evdb/HTTP-Async I'm going to cut a new release in the next few days. - Alex On Wed May 16 11:25:59 2012, ikegami@adaelis.com wrote: Show quoted text
> On Tue, May 15, 2012 at 6:01 AM, evdb@ecclestoad.co.uk via RT < > bug-HTTP-Async@rt.cpan.org> wrote: >
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=77200 > > > > > On 14 May 2012 19:48, ikegami via RT <bug-HTTP-Async@rt.cpan.org> wrote:
> > > Queue: HTTP-Async > > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77200 > > > > > > > The code is not quite right. It should remove requests in to_send and > > > to_return too.
> > > > Could I ask you to do a fork and then submit a pull request on GitHub > > - it really is the easiest way to do this sort of thing. > > > > I'm not an active user of this module anymore - if you'd like to take > > over maintainer-ship that is also an option :) > > > > Cheers, > > Edmund. > >
> > I'll see what I can squeeze in. I've never used the module. (We use > Net::Curl.)