Bug #77190 for MIME-tools: warnings in MIME::Parser

Mon May 14 05:42:38 2012 MSTEVENS [...] cpan.org - Ticket created

CC:	michael.stevens [...] dianomi.com, michael.smith [...] dianomi.com
Subject:	warnings in MIME::Parser

Use of uninitialized value in numeric eq (==) at /opt/dianomi/perl/lib/site_perl/5.12.2/MIME/Parser.pm line 1043. mstevens@303658-admin1:~ % perl -V Summary of my perl5 (revision 5 version 12 subversion 2) configuration: Platform: osname=linux, osvers=2.6.18-194.26.1.el5, archname=x86_64-linux uname='linux 303646-web1.dianomi.co.uk 2.6.18-194.26.1.el5 #1 smp fri oct 29 14:21:16 edt 2010 x86_64 x86_64 x86_64 gnulinux ' config_args='-des -Dprefix=/opt/dianomi/perl -Accflags=-fPIC' hint=recommended, useposix=true, d_sigaction=define useithreads=undef, usemultiplicity=undef useperlio=define, d_sfio=undef, uselargefiles=define, usesocks=undef use64bitint=define, use64bitall=define, uselongdouble=undef usemymalloc=n, bincompat5005=undef Compiler: cc='cc', ccflags ='-fPIC -fno-strict-aliasing -pipe -fstack- protector -I/usr/local/include -D_LARGEFILE_SOURCE - D_FILE_OFFSET_BITS=64', optimize='-O2', cppflags='-fPIC -fno-strict-aliasing -pipe -fstack-protector - I/usr/local/include' ccversion='', gccversion='4.1.2 20080704 (Red Hat 4.1.2-48)', gccosandvers='' intsize=4, longsize=8, ptrsize=8, doublesize=8, byteorder=12345678 d_longlong=define, longlongsize=8, d_longdbl=define, longdblsize=16 ivtype='long', ivsize=8, nvtype='double', nvsize=8, Off_t='off_t', lseeksize=8 alignbytes=8, prototype=define Linker and Libraries: ld='cc', ldflags =' -fstack-protector -L/usr/local/lib' libpth=/usr/local/lib /lib /usr/lib /lib64 /usr/lib64 /usr/local/lib64 libs=-lnsl -ldb -ldl -lm -lcrypt -lutil -lc perllibs=-lnsl -ldl -lm -lcrypt -lutil -lc libc=/lib/libc-2.5.so, so=so, useshrplib=false, libperl=libperl.a gnulibc_version='2.5' Dynamic Linking: dlsrc=dl_dlopen.xs, dlext=so, d_dlsymun=undef, ccdlflags='-Wl,-E' cccdlflags='-fPIC', lddlflags='-shared -O2 -L/usr/local/lib -fstack- protector' Characteristics of this binary (from libperl): Compile-time options: PERL_DONT_CREATE_GVSV PERL_MALLOC_WRAP USE_64_BIT_ALL USE_64_BIT_INT USE_LARGE_FILES USE_PERLIO USE_PERL_ATOF Built under linux Compiled at Jan 11 2011 13:45:15 @INC: /opt/dianomi/perl/lib/site_perl/5.12.2/x86_64-linux /opt/dianomi/perl/lib/site_perl/5.12.2 /opt/dianomi/perl/lib/5.12.2/x86_64-linux /opt/dianomi/perl/lib/5.12.2 . I can have a go at extracting the input that triggers this if required, but am optimistically hoping it'll be obvious what's uninitialized...

Mon May 14 09:43:07 2012 dfs+pause [...] roaringpenguin.com - Taken

Mon May 14 09:46:13 2012 dfs [...] roaringpenguin.com - Correspondence added

Subject:	Re: [rt.cpan.org #77190] warnings in MIME::Parser
Date:	Mon, 14 May 2012 09:45:59 -0400
To:	bug-MIME-tools [...] rt.cpan.org
From:	"David F. Skoll" <dfs [...] roaringpenguin.com>

Hi, On Mon, 14 May 2012 05:42:39 -0400 "Michael Stevens via RT" <bug-MIME-tools@rt.cpan.org> wrote: Show quoted text

> I can have a go at extracting the input that triggers this if > required, but am optimistically hoping it'll be obvious what's > uninitialized...

Does this patch fix it? It's against my git tree so the line numbers might not be exactly right, but it should be pretty obvious what needs changing... Regards, David. --- a/lib/MIME/Parser.pm +++ b/lib/MIME/Parser.pm @@ -1042,7 +1042,7 @@ sub process_part { } elsif (("$type/$subtype" eq "message/rfc822" || "$type/$subtype" eq "message/external-body" || - ("$type/$subtype" eq "message/partial" && $head->mime_attr("content-type.number") == 1)) && + ("$type/$subtype" eq "message/partial" && defined($head->mime_attr("content-type.number")) && $head->mime_attr("content-type.number") == 1)) && $self->extract_nested_messages) { $self->debug("attempting to process a nested message"); return undef unless defined($self->process_message($in, $rdr, $ent));

Mon May 14 09:46:18 2012 The RT System itself - Status changed from 'new' to 'open'

Mon May 21 10:35:56 2012 mstevens [...] etla.org - Correspondence added

CC:	MSTEVENS [...] cpan.org, michael.smith [...] dianomi.com, michael.stevens [...] dianomi.com
Subject:	Re: [rt.cpan.org #77190] warnings in MIME::Parser
Date:	Mon, 21 May 2012 15:35:34 +0100
To:	"David F. Skoll via RT" <bug-MIME-tools [...] rt.cpan.org>
From:	Michael Stevens <mstevens [...] etla.org>

On Mon, May 14, 2012 at 09:46:16AM -0400, David F. Skoll via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=77190 > > > Hi, > > On Mon, 14 May 2012 05:42:39 -0400 > "Michael Stevens via RT" <bug-MIME-tools@rt.cpan.org> wrote: >

> > I can have a go at extracting the input that triggers this if > > required, but am optimistically hoping it'll be obvious what's > > uninitialized...

> > Does this patch fix it? It's against my git tree so the line numbers > might not be exactly right, but it should be pretty obvious what needs > changing... > > Regards, > > David. > > --- a/lib/MIME/Parser.pm > +++ b/lib/MIME/Parser.pm > @@ -1042,7 +1042,7 @@ sub process_part { > } > elsif (("$type/$subtype" eq "message/rfc822" || > "$type/$subtype" eq "message/external-body" || > - ("$type/$subtype" eq "message/partial" && $head->mime_attr("content-type.number") == 1)) && > + ("$type/$subtype" eq "message/partial" && defined($head->mime_attr("content-type.number")) && $head->mime_attr("content-type.number") == 1)) && > $self->extract_nested_messages) { > $self->debug("attempting to process a nested message"); > return undef unless defined($self->process_message($in, $rdr, > $ent)); >

Thanks, testing this now. Looks good so far. Michael

Fri Jun 08 10:00:22 2012 dfs+pause [...] roaringpenguin.com - Correspondence added

Hi, I have just uploaded MIME-tools-5.503 to CPAN, which I believe resolves this ticket. Regards, David.

Fri Jun 08 10:00:22 2012 dfs+pause [...] roaringpenguin.com - Status changed from 'open' to 'resolved'