Skip Menu |

This queue is for tickets about the COPS-Client CPAN distribution.

Report information
The Basics
Id: 77184
Status: resolved
Priority: 0/
Queue: COPS-Client

People
Owner: shamrock [...] cpan.org
Requestors: ivan.prostran [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 0.01



Subject: GateSet (GateID)
Date: Sun, 13 May 2012 23:39:54 +0200
To: bug-COPS-Client [...] rt.cpan.org
From: Ivan Prostran <ivan.prostran [...] gmail.com>
Hello , Referring to PKT-SP-MM-I05-091029 : 6.5.6 Procedures for Modifying a Gate Show quoted text
> > To modify the Traffic Profile associated with an existing Gate, an > Application Manager MAY send a Gate-Set > message with the GateID of the Gate to be modified and the new Traffic > Profile. >
To achieve this, the following patch should be applied. +++ Client.pm 2012-05-13 23:36:03.353298461 +0200 @@ -1030,6 +1030,11 @@ my $amid_command = $self->encode_sub_amid(1,1); my $subscriber_command = $self->encode_sub_subscriber_id( $self->subscriber_type(),$subscriber_ip); + my $gate_id; + if ( $self->get_gate_id() ) + { + $gate_id = $self->encode_gate_id (); + } my $total_object; @@ -1059,6 +1064,7 @@ $gate_command. $amid_command. $subscriber_command. + $gate_id. $total_object ); If you have any other suggestion, please let me know. Regards, Ivan Prostran
Hi, Your patch has been added and should be live within a couple of hours. Thanks for information, always happy to add the module. Shamrock On Sun May 13 17:40:06 2012, ivan.prostran@gmail.com wrote: Show quoted text
> Hello , > > Referring to PKT-SP-MM-I05-091029 : > > 6.5.6 Procedures for Modifying a Gate
> > > > To modify the Traffic Profile associated with an existing Gate, an > > Application Manager MAY send a Gate-Set > > message with the GateID of the Gate to be modified and the new Traffic > > Profile. > >
> > To achieve this, the following patch should be applied. > > +++ Client.pm 2012-05-13 23:36:03.353298461 +0200 > @@ -1030,6 +1030,11 @@ > my $amid_command = $self->encode_sub_amid(1,1); > my $subscriber_command = $self->encode_sub_subscriber_id( > $self->subscriber_type(),$subscriber_ip); > + my $gate_id; > + if ( $self->get_gate_id() ) > + { > + $gate_id = $self->encode_gate_id (); > + } > > my $total_object; > > @@ -1059,6 +1064,7 @@ > $gate_command. > $amid_command. > $subscriber_command. > + $gate_id. > $total_object > ); > > > > If you have any other suggestion, please let me know. > > Regards, > Ivan Prostran
Subject: Re: [rt.cpan.org #77184] GateSet (GateID)
Date: Mon, 14 May 2012 13:08:42 +0100 (BST)
To: Ivan Prostran via RT <bug-COPS-Client [...] rt.cpan.org>
From: "Andrew S. Kennedy" <shamrock [...] cpan.org>
Hi, The module has now been updated with your patch. I can not test it however should work as you have described. Andrew. On Sun, 13 May 2012, Ivan Prostran via RT wrote: Show quoted text
> Sun May 13 17:40:06 2012: Request 77184 was acted upon. > Transaction: Ticket created by ivan.prostran@gmail.com > Queue: COPS-Client > Subject: GateSet (GateID) > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: ivan.prostran@gmail.com > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77184 > > > > Hello , > > Referring to PKT-SP-MM-I05-091029 : > > 6.5.6 Procedures for Modifying a Gate
>> >> To modify the Traffic Profile associated with an existing Gate, an >> Application Manager MAY send a Gate-Set >> message with the GateID of the Gate to be modified and the new Traffic >> Profile. >>
> > To achieve this, the following patch should be applied. > > +++ Client.pm 2012-05-13 23:36:03.353298461 +0200 > @@ -1030,6 +1030,11 @@ > my $amid_command = $self->encode_sub_amid(1,1); > my $subscriber_command = $self->encode_sub_subscriber_id( > $self->subscriber_type(),$subscriber_ip); > + my $gate_id; > + if ( $self->get_gate_id() ) > + { > + $gate_id = $self->encode_gate_id (); > + } > > my $total_object; > > @@ -1059,6 +1064,7 @@ > $gate_command. > $amid_command. > $subscriber_command. > + $gate_id. > $total_object > ); > > > > If you have any other suggestion, please let me know. > > Regards, > Ivan Prostran > >
Subject: Re: [rt.cpan.org #77184] GateSet (GateID)
Date: Mon, 14 May 2012 14:28:02 +0200
To: bug-COPS-Client [...] rt.cpan.org
From: Ivan Prostran <ivan.prostran [...] gmail.com>
Hi, Yesterday I made some tests and everything worked as expected. Anyway, I'll let you know if some problems occur. Regards, Ivan On Mon, May 14, 2012 at 2:08 PM, Andrew S. Kennedy via RT <bug-COPS-Client@rt.cpan.org> wrote: Show quoted text
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=77184 > > > Hi, >        The module has now been updated with your patch. I can not test it > however should work as you have described. > > Andrew. > > On Sun, 13 May 2012, Ivan Prostran via RT wrote: >
> > Sun May 13 17:40:06 2012: Request 77184 was acted upon. > > Transaction: Ticket created by ivan.prostran@gmail.com > >       Queue: COPS-Client > >     Subject: GateSet (GateID) > >   Broken in: (no value) > >    Severity: (no value) > >       Owner: Nobody > >  Requestors: ivan.prostran@gmail.com > >      Status: new > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77184 > > > > > > > Hello , > > > > Referring to PKT-SP-MM-I05-091029 : > > > > 6.5.6 Procedures for Modifying a Gate
> >> > >> To modify the Traffic Profile associated with an existing Gate, an > >> Application Manager MAY send a Gate-Set > >> message with the GateID of the Gate to be modified and the new Traffic > >> Profile. > >>
> > > > To achieve this, the following  patch should be applied. > > > > +++ Client.pm    2012-05-13 23:36:03.353298461 +0200 > > @@ -1030,6 +1030,11 @@ > >                 my $amid_command = $self->encode_sub_amid(1,1); > >                 my $subscriber_command = $self->encode_sub_subscriber_id( > >                                 $self->subscriber_type(),$subscriber_ip); > > +                my $gate_id; > > +                if ( $self->get_gate_id() ) > > +                    { > > +                    $gate_id = $self->encode_gate_id (); > > +                    } > > > >                 my $total_object; > > > > @@ -1059,6 +1064,7 @@ > >                     $gate_command. > >                     $amid_command. > >                     $subscriber_command. > > +                    $gate_id. > >                     $total_object > >                     ); > > > > > > > > If you have any other suggestion,  please let me know. > > > > Regards, > > Ivan Prostran > > > >
>
this was patched and never closed. Closing this bug.