Subject: | multi_content_type.t unfortunately may be skipped silently |
One of my smokers recently reported a fail on the multi_content_type.t
test. I'm still investigating what might be the cause and when I have
some evidence I'll open another ticket. For now I want to suggest that
the test should not pass so silently when the catalyst server on 7357
does not work. At least a diag should be issued, maybe even a fail would
be appropriate. Or a diag which collects hints about possible reasons.
This is the current code:
TRY_CONNECT: {
eval { $m->get('/') };
if ($@ || $m->content =~ /Can't connect to \w+:$PORT/) {
$skip = $@ || $m->content;
}
}
The variable $skip now is only passed to the skip function which is
normally only displayed when the user asks for verbosity. But
cpantesters do not and should not ask vor extra verbosity, the default
verbosity must be good enough to recognize that the server could not be
started and why.
Makes sense?