Skip Menu |

This queue is for tickets about the Plack-Middleware-ReverseProxy CPAN distribution.

Report information
The Basics
Id: 77158
Status: resolved
Priority: 0/
Queue: Plack-Middleware-ReverseProxy
People
Owner: Nobody in particular
Requestors: KENTNL [...] cpan.org
ribasushi [...] leporine.io
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Sat May 12 04:22:43 2012 ribasushi [...] leporine.io - Ticket created
Subject: Fails a test with latest plack.
rabbit@Ahasver:~$ cpanm -v Plack Plack::Middleware::ReverseProxy cpanm (App::cpanminus) 1.5007 on perl 5.014002 built for x86_64-linux-thread-multi-ld Work directory is /home/rabbit/.cpanm/work/1336810878.1090 You have make /usr/bin/make You have LWP 6.04 You have /bin/tar: tar (GNU tar) 1.23 Copyright (C) 2010 Free Software Foundation, Inc. License GPLv3+: GNU GPL version 3 or later <http://gnu.org/licenses/gpl.html>. This is free software: you are free to change and redistribute it. There is NO WARRANTY, to the extent permitted by law. Written by John Gilmore and Jay Fenlason. You have /usr/bin/unzip Searching Plack on cpanmetadb ... Plack is up to date. (0.9988) Searching Plack::Middleware::ReverseProxy on cpanmetadb ... --> Working on Plack::Middleware::ReverseProxy Fetching http://search.cpan.org/CPAN/authors/id/D/DA/DANJOU/Plack-Middleware-ReverseProxy-0.11.tar.gz ... OK Unpacking Plack-Middleware-ReverseProxy-0.11.tar.gz Plack-Middleware-ReverseProxy-0.11/ Plack-Middleware-ReverseProxy-0.11/Changes Plack-Middleware-ReverseProxy-0.11/inc/ Plack-Middleware-ReverseProxy-0.11/inc/Module/ Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/ Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/AuthorTests.pm Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Base.pm Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Can.pm Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Fetch.pm Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Makefile.pm Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Metadata.pm Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Repository.pm Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Win32.pm Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/WriteAll.pm Plack-Middleware-ReverseProxy-0.11/inc/Module/Install.pm Plack-Middleware-ReverseProxy-0.11/lib/ Plack-Middleware-ReverseProxy-0.11/lib/Plack/ Plack-Middleware-ReverseProxy-0.11/lib/Plack/Middleware/ Plack-Middleware-ReverseProxy-0.11/lib/Plack/Middleware/ReverseProxy.pm Plack-Middleware-ReverseProxy-0.11/Makefile.PL Plack-Middleware-ReverseProxy-0.11/MANIFEST Plack-Middleware-ReverseProxy-0.11/META.yml Plack-Middleware-ReverseProxy-0.11/README Plack-Middleware-ReverseProxy-0.11/t/ Plack-Middleware-ReverseProxy-0.11/t/00_compile.t Plack-Middleware-ReverseProxy-0.11/t/lib/ Plack-Middleware-ReverseProxy-0.11/t/lib/Plack/ Plack-Middleware-ReverseProxy-0.11/t/lib/Plack/Middleware/ Plack-Middleware-ReverseProxy-0.11/t/lib/Plack/Middleware/MangleEnv.pm Plack-Middleware-ReverseProxy-0.11/t/reverseproxy.t Plack-Middleware-ReverseProxy-0.11/xt/ Plack-Middleware-ReverseProxy-0.11/xt/01_podspell.t Plack-Middleware-ReverseProxy-0.11/xt/02_perlcritic.t Plack-Middleware-ReverseProxy-0.11/xt/03_pod.t Plack-Middleware-ReverseProxy-0.11/xt/perlcriticrc Entering Plack-Middleware-ReverseProxy-0.11 Checking configure dependencies from META.yml Checking if you have ExtUtils::MakeMaker 6.42 ... Yes (6.62) Configuring Plack-Middleware-ReverseProxy-0.11 ... Running Makefile.PL Checking if your kit is complete... Looks good Writing Makefile for Plack::Middleware::ReverseProxy Writing MYMETA.yml and MYMETA.json OK Checking dependencies from MYMETA.json ... Checking if you have Test::More 0 ... Yes (0.98) Checking if you have Test::Base 0 ... Yes (0.60) Checking if you have ExtUtils::MakeMaker 6.42 ... Yes (6.62) Checking if you have Plack::Middleware 0 ... Yes (undef) Checking if you have parent 0 ... Yes (0.225) Checking if you have YAML 0 ... Yes (0.80) Checking if you have Plack::Request 0 ... Yes (0.9988) Building and testing Plack-Middleware-ReverseProxy-0.11 ... cp lib/Plack/Middleware/ReverseProxy.pm blib/lib/Plack/Middleware/ReverseProxy.pm Manifying blib/man3/Plack::Middleware::ReverseProxy.3 PERL_DL_NONLAZY=1 /home/rabbit/perl5/perlbrew/perls/5.14.2/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', 'blib/arch')" t/*.t t/00_compile.t .... ok t/reverseproxy.t .. 1/39 # Failed test 'with https of uri' # at t/reverseproxy.t line 33. # got: 'https://example.com/?foo=bar' # expected: 'https://example.com:80/?foo=bar' # Failed test 'with https of base' # at t/reverseproxy.t line 33. # got: 'https://example.com/' # expected: 'https://example.com:80/' # Failed test 'https with HTTP_X_FORWARDED_PROTO of uri' # at t/reverseproxy.t line 33. # got: 'https://example.com/?foo=bar' # expected: 'https://example.com:80/?foo=bar' # Failed test 'https with HTTP_X_FORWARDED_PROTO of base' # at t/reverseproxy.t line 33. # got: 'https://example.com/' # expected: 'https://example.com:80/' # Looks like you failed 4 tests of 39. t/reverseproxy.t .. Dubious, test returned 4 (wstat 1024, 0x400) Failed 4/39 subtests Test Summary Report ------------------- t/reverseproxy.t (Wstat: 1024 Tests: 39 Failed: 4) Failed tests: 2-3, 9-10 Non-zero exit status: 4 Files=2, Tests=40, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.18 cusr 0.02 csys = 0.24 CPU) Result: FAIL Failed 1/2 test programs. 4/40 subtests failed. make: *** [test_dynamic] Error 4 FAIL
  Sat May 12 04:41:57 2012 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #77158] Fails a test with latest plack.
Date: Sat, 12 May 2012 11:41:37 +0300
To: bug-Plack-Middleware-ReverseProxy [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
yeah there's a pull req on github - test it and close this one please :) -- Tatsuhiko Miyagawa On Saturday, May 12, 2012 at 11:22 AM, Peter Rabbitson via RT wrote: Show quoted text
> Sat May 12 04:22:43 2012: Request 77158 was acted upon. > Transaction: Ticket created by RIBASUSHI > Queue: Plack-Middleware-ReverseProxy > Subject: Fails a test with latest plack. > Broken in: (no value) > Severity: (no value) > Owner: Nobody > Requestors: ribasushi@cpan.org (mailto:ribasushi@cpan.org) > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77158 > > > > rabbit@Ahasver:~$ cpanm -v Plack Plack::Middleware::ReverseProxy > > cpanm (App::cpanminus) 1.5007 on perl 5.014002 built for > x86_64-linux-thread-multi-ld > Work directory is /home/rabbit/.cpanm/work/1336810878.1090 > You have make /usr/bin/make > You have LWP 6.04 > You have /bin/tar: tar (GNU tar) 1.23 > Copyright (C) 2010 Free Software Foundation, Inc. > License GPLv3+: GNU GPL version 3 or later > <http://gnu.org/licenses/gpl.html>. > This is free software: you are free to change and redistribute it. > There is NO WARRANTY, to the extent permitted by law. > > Written by John Gilmore and Jay Fenlason. > You have /usr/bin/unzip > Searching Plack on cpanmetadb ... > > Plack is up to date. (0.9988) > > Searching Plack::Middleware::ReverseProxy on cpanmetadb ... > --> Working on Plack::Middleware::ReverseProxy > Fetching > http://search.cpan.org/CPAN/authors/id/D/DA/DANJOU/Plack-Middleware-ReverseProxy-0.11.tar.gz > ... OK > Unpacking Plack-Middleware-ReverseProxy-0.11.tar.gz > Plack-Middleware-ReverseProxy-0.11/ > Plack-Middleware-ReverseProxy-0.11/Changes > Plack-Middleware-ReverseProxy-0.11/inc/ > Plack-Middleware-ReverseProxy-0.11/inc/Module/ > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/ > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/AuthorTests.pm > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Base.pm > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Can.pm > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Fetch.pm > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Makefile.pm > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Metadata.pm > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Repository.pm > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/Win32.pm > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install/WriteAll.pm > Plack-Middleware-ReverseProxy-0.11/inc/Module/Install.pm > Plack-Middleware-ReverseProxy-0.11/lib/ > Plack-Middleware-ReverseProxy-0.11/lib/Plack/ > Plack-Middleware-ReverseProxy-0.11/lib/Plack/Middleware/ > Plack-Middleware-ReverseProxy-0.11/lib/Plack/Middleware/ReverseProxy.pm > Plack-Middleware-ReverseProxy-0.11/Makefile.PL > Plack-Middleware-ReverseProxy-0.11/MANIFEST > Plack-Middleware-ReverseProxy-0.11/META.yml > Plack-Middleware-ReverseProxy-0.11/README > Plack-Middleware-ReverseProxy-0.11/t/ > Plack-Middleware-ReverseProxy-0.11/t/00_compile.t > Plack-Middleware-ReverseProxy-0.11/t/lib/ > Plack-Middleware-ReverseProxy-0.11/t/lib/Plack/ > Plack-Middleware-ReverseProxy-0.11/t/lib/Plack/Middleware/ > Plack-Middleware-ReverseProxy-0.11/t/lib/Plack/Middleware/MangleEnv.pm > Plack-Middleware-ReverseProxy-0.11/t/reverseproxy.t > Plack-Middleware-ReverseProxy-0.11/xt/ > Plack-Middleware-ReverseProxy-0.11/xt/01_podspell.t > Plack-Middleware-ReverseProxy-0.11/xt/02_perlcritic.t > Plack-Middleware-ReverseProxy-0.11/xt/03_pod.t > Plack-Middleware-ReverseProxy-0.11/xt/perlcriticrc > Entering Plack-Middleware-ReverseProxy-0.11 > Checking configure dependencies from META.yml > Checking if you have ExtUtils::MakeMaker 6.42 ... Yes (6.62) > Configuring Plack-Middleware-ReverseProxy-0.11 ... Running Makefile.PL > Checking if your kit is complete... > Looks good > Writing Makefile for Plack::Middleware::ReverseProxy > Writing MYMETA.yml and MYMETA.json > OK > Checking dependencies from MYMETA.json ... > Checking if you have Test::More 0 ... Yes (0.98) > Checking if you have Test::Base 0 ... Yes (0.60) > Checking if you have ExtUtils::MakeMaker 6.42 ... Yes (6.62) > Checking if you have Plack::Middleware 0 ... Yes (undef) > Checking if you have parent 0 ... Yes (0.225) > Checking if you have YAML 0 ... Yes (0.80) > Checking if you have Plack::Request 0 ... Yes (0.9988) > Building and testing Plack-Middleware-ReverseProxy-0.11 ... cp > lib/Plack/Middleware/ReverseProxy.pm > blib/lib/Plack/Middleware/ReverseProxy.pm > Manifying blib/man3/Plack::Middleware::ReverseProxy.3 > PERL_DL_NONLAZY=1 /home/rabbit/perl5/perlbrew/perls/5.14.2/bin/perl > "-MExtUtils::Command::MM" "-e" "test_harness(0, 'inc', 'blib/lib', > 'blib/arch')" t/*.t > t/00_compile.t .... ok > t/reverseproxy.t .. 1/39 > # Failed test 'with https of uri' > # at t/reverseproxy.t line 33. > # got: 'https://example.com/?foo=bar' > # expected: 'https://example.com:80/?foo=bar' > > # Failed test 'with https of base' > # at t/reverseproxy.t line 33. > # got: 'https://example.com/' > # expected: 'https://example.com:80/' > > # Failed test 'https with HTTP_X_FORWARDED_PROTO of uri' > # at t/reverseproxy.t line 33. > # got: 'https://example.com/?foo=bar' > # expected: 'https://example.com:80/?foo=bar' > > # Failed test 'https with HTTP_X_FORWARDED_PROTO of base' > # at t/reverseproxy.t line 33. > # got: 'https://example.com/' > # expected: 'https://example.com:80/' > # Looks like you failed 4 tests of 39. > t/reverseproxy.t .. Dubious, test returned 4 (wstat 1024, 0x400) > Failed 4/39 subtests > > Test Summary Report > ------------------- > t/reverseproxy.t (Wstat: 1024 Tests: 39 Failed: 4) > Failed tests: 2-3, 9-10 > Non-zero exit status: 4 > Files=2, Tests=40, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.18 cusr > 0.02 csys = 0.24 CPU) > Result: FAIL > Failed 1/2 test programs. 4/40 subtests failed. > make: *** [test_dynamic] Error 4 > FAIL > >
  Sat May 12 04:41:59 2012 The RT System itself - Status changed from 'new' to 'open'
  Sat May 12 05:21:16 2012 ribasushi [...] leporine.io - Correspondence added
On Sat May 12 04:41:57 2012, miyagawa@gmail.com wrote: Show quoted text
> yeah there's a pull req on github - test it and close this one please :) >
I couldn't find a pull req, I suspect you meant this: https://github.com/doy/Plack-Middleware-ReverseProxy/commit/d2a6d8a5. Tested - it does pass tests correctly now. As far as closing the ticket we probably should do this after a release is cut no? Or if you want to transition to github issues wholesale you should probably adjust the 'bugtracker' meta resource to point to github...?
  Sun May 13 02:25:50 2012 d.thomas [...] its.uq.edu.au - Correspondence added
From: d.thomas [...] its.uq.edu.au
doy-Plack-Middleware-ReverseProxy-d2a6d8a seems to fail with perl-5.16.0-RC0 /opt/perl/uq.is.perl.rhel5-5.16.0-RC0-20120513/bin/perl M*PL include /opt/perl/uq.is.perl.rhel5-5.16.0-RC0-20120513.build/tarball-build/Plack- Middleware-ReverseProxy-0.11/inc/Module/Install.pm String found where operator expected at Makefile.PL line 12, near "author_tests 'xt'" (Do you need to predeclare author_tests?) syntax error at Makefile.PL line 12, near "author_tests 'xt'" Bareword "auto_set_repository" not allowed while "strict subs" in use at Makefile.PL line 16. Execution of Makefile.PL aborted due to compilation errors. commented-out these 2 lines #author_tests 'xt'; #auto_set_repository; now PASSes tests
  Sun May 13 02:29:30 2012 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #77158] Fails a test with latest plack.
Date: Sun, 13 May 2012 09:29:14 +0300
To: bug-Plack-Middleware-ReverseProxy [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
No, that's a packaging/authoring issue, you install Module::Install::AuthorTests and Module::Install::Repository (only required for the dev/author side) and it will work. -- Tatsuhiko Miyagawa On Sunday, May 13, 2012 at 9:25 AM, d.thomas@its.uq.edu.au via RT wrote: Show quoted text
> Queue: Plack-Middleware-ReverseProxy > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77158 > > > doy-Plack-Middleware-ReverseProxy-d2a6d8a seems to fail with perl-5.16.0-RC0 > > /opt/perl/uq.is.perl.rhel5-5.16.0-RC0-20120513/bin/perl M*PL > include /opt/perl/uq.is.perl.rhel5-5.16.0-RC0-20120513.build/tarball-build/Plack- > Middleware-ReverseProxy-0.11/inc/Module/Install.pm > String found where operator expected at Makefile.PL line 12, near "author_tests 'xt'" > (Do you need to predeclare author_tests?) > syntax error at Makefile.PL line 12, near "author_tests 'xt'" > Bareword "auto_set_repository" not allowed while "strict subs" in use at Makefile.PL line 16. > Execution of Makefile.PL aborted due to compilation errors. > > > commented-out these 2 lines > #author_tests 'xt'; > #auto_set_repository; > > now PASSes tests
  Sun May 13 02:37:08 2012 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #77158] Fails a test with latest plack.
Date: Sun, 13 May 2012 09:36:42 +0300
To: bug-Plack-Middleware-ReverseProxy [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
Fixed in 0.12 -- Tatsuhiko Miyagawa On Sunday, May 13, 2012 at 9:29 AM, miyagawa@gmail.com via RT wrote: Show quoted text
> Queue: Plack-Middleware-ReverseProxy > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77158 > > > No, that's a packaging/authoring issue, you install Module::Install::AuthorTests and Module::Install::Repository (only required for the dev/author side) and it will work. > > -- > Tatsuhiko Miyagawa > > > On Sunday, May 13, 2012 at 9:25 AM, d.thomas@its.uq.edu.au (mailto:d.thomas@its.uq.edu.au) via RT wrote: >
> > Queue: Plack-Middleware-ReverseProxy > > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77158 > > > > > doy-Plack-Middleware-ReverseProxy-d2a6d8a seems to fail with perl-5.16.0-RC0 > > > > /opt/perl/uq.is.perl.rhel5-5.16.0-RC0-20120513/bin/perl M*PL > > include /opt/perl/uq.is.perl.rhel5-5.16.0-RC0-20120513.build/tarball-build/Plack- > > Middleware-ReverseProxy-0.11/inc/Module/Install.pm > > String found where operator expected at Makefile.PL line 12, near "author_tests 'xt'" > > (Do you need to predeclare author_tests?) > > syntax error at Makefile.PL line 12, near "author_tests 'xt'" > > Bareword "auto_set_repository" not allowed while "strict subs" in use at Makefile.PL line 16. > > Execution of Makefile.PL aborted due to compilation errors. > > > > > > commented-out these 2 lines > > #author_tests 'xt'; > > #auto_set_repository; > > > > now PASSes tests
  Sat May 26 21:30:04 2012 KENTNL [...] cpan.org - Correspondence added
On 2012-05-13 18:37:08, miyagawa@gmail.com wrote: Show quoted text
> Fixed in 0.12 >
Still get this failure in MIYAGAWA/Plack-Middleware-ReverseProxy-0.13 with Plack 0.9984 , perhaps a minimum Plack version needs to be declared?
  Sat May 26 21:30:33 2012 KENTNL [...] cpan.org - Requestor KENTNL added
  Sat May 26 23:18:59 2012 miyagawa [...] gmail.com - Correspondence added
Subject: Re: [rt.cpan.org #77158] Fails a test with latest plack.
Date: Sat, 26 May 2012 20:18:30 -0700
To: bug-Plack-Middleware-ReverseProxy [...] rt.cpan.org
From: Tatsuhiko Miyagawa <miyagawa [...] gmail.com>
Quite possible. Try upgrading Plack first. On Sat, May 26, 2012 at 6:30 PM, Kent Fredric via RT <bug-Plack-Middleware-ReverseProxy@rt.cpan.org> wrote: Show quoted text
>       Queue: Plack-Middleware-ReverseProxy >  Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=77158 > > > On 2012-05-13 18:37:08, miyagawa@gmail.com wrote:
>> Fixed in 0.12 >>
> > > Still get this failure in MIYAGAWA/Plack-Middleware-ReverseProxy-0.13 with Plack 0.9984 , perhaps a minimum Plack version needs to be declared? > >
-- Tatsuhiko Miyagawa
  Sat May 26 23:51:24 2012 KENTNL [...] cpan.org - Correspondence added
On 2012-05-27 15:18:59, miyagawa@gmail.com wrote: Show quoted text
> Quite possible. Try upgrading Plack first.
Confirming, Upgrading to Plack 0.9988 solves this issue, and thus this bug should be resolved for all in 0.14
  Sun Nov 04 15:27:55 2012 ribasushi [...] leporine.io - Correspondence added
Fix confirmed
  Sun Nov 04 15:27:57 2012 ribasushi [...] leporine.io - Status changed from 'open' to 'resolved'