Skip Menu |

This queue is for tickets about the Net-SFTP-Foreign CPAN distribution.

Report information
The Basics
Id: 77118
Status: resolved
Worked: 30 min
Priority: 0/
Queue: Net-SFTP-Foreign
People
Owner: Nobody in particular
Requestors: DOUGW [...] cpan.org
Cc:
AdminCc:
Bug Information
Severity: Critical
Broken in: 1.72_02
Fixed in: (no value)

History Show all quoted text
  Thu May 10 20:35:01 2012 DOUGW [...] cpan.org - Ticket created
Password authentication hangs on Unix (solaris). This code: if (waitpid $child, 64 > 0) { has a precedence problem. Should be: if (waitpid($child, 64) > 0) {
  Thu May 10 20:37:59 2012 DOUGW [...] cpan.org - Subject changed from (no value) to 'Password auth hangs'
  Thu May 10 20:40:16 2012 DOUGW [...] cpan.org - Correspondence added
On Thu May 10 20:35:01 2012, DOUGW wrote: Show quoted text
> if (waitpid($child, 64) > 0) {
While I was debugging and trying different things, I changed POSIX::WNOHANG() to 64 (that's what it is on solaris). Of course, the code should be: if (waitpid($child, POSIX::WNOHANG()) > 0) {
  Thu May 10 20:40:17 2012 DOUGW [...] cpan.org - Status changed from 'new' to 'open'
  Thu May 10 21:55:09 2012 DOUGW [...] cpan.org - Subject changed from 'Password auth hangs' to 'Password auth hangs on solaris'
  Thu May 10 21:57:38 2012 DOUGW [...] cpan.org - Correspondence added
On Thu May 10 20:40:16 2012, DOUGW wrote: Show quoted text
> > Of course, the code should be: > if (waitpid($child, POSIX::WNOHANG()) > 0) {
And I've only just realized that normally, WNOHANG is 1, and (1 > 0) evaluates to 1, and so the broken version actually works on most OS's :-)
  Fri May 11 08:28:23 2012 salva [...] cpan.org - Correspondence added 30 min
good catch, thank you for reporting it! Also solved in 1.73 (https://metacpan.org/release/SALVA/Net-SFTP-Foreign-1.73).
  Fri May 11 08:28:24 2012 salva [...] cpan.org - Status changed from 'open' to 'resolved'