Skip Menu |

This queue is for tickets about the Log-Common CPAN distribution.

Report information
The Basics
Id: 771
Status: new
Priority: 0/
Queue: Log-Common
People
Owner: Nobody in particular
Requestors: frag [...] enteract.com
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Fri Jun 21 10:48:52 2002 Guest - Ticket created
Subject: missing dollar sign in Log::Common
This is a bug in Log-Common 1.00 (which is, a little suprisingly to me, the most recent version). The dollar sign is missing from a scalar argument to flock; what should be $LOG is given as LOG. Consequently, this module gives the following error on each call to the error() method: flock() on closed filehandle Log::Common::LOG at /usr/local/wsinfo/lib/Log/Common.pm line 78. This is in 5.6.0, if that matters in this case, using the code straight from the SYNOPSIS section of the module's pod. I've enclosed a patch. This the first time I've ever sent any sort of patch - if it's not in the right format, let me know. -- Mike F.
  Fri Jun 21 10:56:12 2002 frag [...] enteract.com - Correspondence added
Date: Fri, 21 Jun 2002 09:56:10 -0500 (CDT)
From: Mike Fragassi <frag [...] enteract.com>
To: Log-Common <bug-Log-Common [...] rt.cpan.org>
Subject: Re: [cpan #771] AutoReply: missing dollar sign in Log::Common
Assuming the full-headers web page for the bug is supposed to include attachments, then lynx did not include the patch attachment I specified in the form. I've included the patch below. -- Mike F. --- Common.pm~ Fri Oct 16 12:37:10 1998 +++ Common.pm Fri Jun 21 08:58:26 2002 @@ -75,7 +75,7 @@ print $LOG "($info)" if defined($info); print $LOG "\n"; - flock(LOG, 8); # unlock after writing + flock($LOG, 8); # unlock after writing croak($args{fatal}) if defined($args{fatal}); }