Skip Menu |

This queue is for tickets about the Nagios-Scrape CPAN distribution.

Report information
The Basics
Id: 77056
Status: rejected
Priority: 0/
Queue: Nagios-Scrape

People
Owner: Nobody in particular
Requestors: frost.raphael [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in:
  • 0.01
  • 0.02
  • 0.03
Fixed in: (no value)



Subject: service_state() always returns the number given to it
service_state() always returns the number given to it (so by default 28). service_state(1) returns 1 service_state(2) returns 2 service_state(3) returns 3 ...
Firstly, this response is hilariously late, I've just taken over maintainership of this dist. I'm not sure I consider this a bug - certainly not a critical one. IME, it's fairly common for a mutator to return the new value given to it, and it's somewhat a matter of taste whether it returns that, or a boolean to indicate whether the value could be set or not, or sometimes the object itself to allow for chained method calls. At this point in the module's life, I don't think it's worth changing it, in case people are relying on the current behaviour. Cheers Dave P