Skip Menu |

This queue is for tickets about the PowerDNS-Backend-MySQL CPAN distribution.

Report information
The Basics
Id: 76908
Status: resolved
Priority: 0/
Queue: PowerDNS-Backend-MySQL
People
Owner: Nobody in particular
Requestors: rvincelette [...] athenahealth.com
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Mon Apr 30 18:27:18 2012 rvincelette [...] athenahealth.com - Ticket created
Subject: allow non native add_domain option
Date: Mon, 30 Apr 2012 18:26:55 -0400
To: bug-PowerDNS-Backend-MySQL [...] rt.cpan.org
From: Rich Vincelette <rvincelette [...] athenahealth.com>
Hello, While using this module I have found it would be great if one could optionally add_domain with MASTER vs NATIVE and/or add a function make_domain_master much like the make_domain_native. Personally I have modified add_domain to always create as MASTER, and if need be I can afterwards make_domain_native. Thank you for your time and effort The module has already saved me hours Thanks again and feel free to reach out if I haven't explained this clearly or if I'm just missing something already in the module. -Red
  Mon Apr 30 19:53:05 2012 augie.schwer [...] gmail.com - Correspondence added
On Mon Apr 30 18:27:18 2012, rvincelette@athenahealth.com wrote: Show quoted text
> While using this module I have found it would be great if one could > optionally add_domain with MASTER vs NATIVE and/or add a function > make_domain_master much like the make_domain_native. > Personally I have modified add_domain to always create as MASTER, and
if Show quoted text
> need be I can afterwards make_domain_native.
Red, will you submit a patch with the new functions "add_master" and "make_domain_master", and test them out? Then I can add them to the module. --Augie
  Mon Apr 30 19:53:05 2012 The RT System itself - Status changed from 'new' to 'open'
  Mon May 07 11:33:18 2012 rvincelette [...] athenahealth.com - Correspondence added
Subject: Re: [rt.cpan.org #76908] allow non native add_domain option
Date: Mon, 7 May 2012 11:33:05 -0400
To: "bug-PowerDNS-Backend-MySQL [...] rt.cpan.org" <bug-PowerDNS-Backend-MySQL [...] rt.cpan.org>
From: Rich Vincelette <rvincelette [...] athenahealth.com>
Augie, I've attached the diff/patch of my changes to the MySQL.pm. I have tested and used these in our development environment for a week now, and I will be pushing them into our production environment today so I figured now was a good time to send them to you, let me know if you see any issues with it, but it's currently working for us. I'm running perl 5.8.8 on RHEL/CentOS 5.7 thanks for your quick responses -Red On 04/30/2012 07:53 PM, Augie Schwer via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=76908> > > On Mon Apr 30 18:27:18 2012, rvincelette@athenahealth.com wrote:
>> While using this module I have found it would be great if one could >> optionally add_domain with MASTER vs NATIVE and/or add a function >> make_domain_master much like the make_domain_native. >> Personally I have modified add_domain to always create as MASTER, and
> if
>> need be I can afterwards make_domain_native.
> > Red, will you submit a patch with the new functions "add_master" and > "make_domain_master", and test them out? Then I can add them to the > module. --Augie >

Message body is not shown because sender requested not to inline it.

  Fri Aug 03 19:32:30 2012 augie.schwer [...] gmail.com - Correspondence added
Patch applied and released into v0.11 . --Augie On Mon May 07 11:33:18 2012, rvincelette@athenahealth.com wrote: Show quoted text
> Augie, > I've attached the diff/patch of my changes to the MySQL.pm. I have > tested and used these in our development environment for a week now,
and Show quoted text
> I will be pushing them into our production environment today so I > figured now was a good time to send them to you, let me know if you
see Show quoted text
> any issues with it, but it's currently working for us. > > I'm running perl 5.8.8 on RHEL/CentOS 5.7 > > thanks for your quick responses > -Red > > On 04/30/2012 07:53 PM, Augie Schwer via RT wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=76908> > > > > On Mon Apr 30 18:27:18 2012, rvincelette@athenahealth.com wrote:
> >> While using this module I have found it would be great if one could > >> optionally add_domain with MASTER vs NATIVE and/or add a function > >> make_domain_master much like the make_domain_native. > >> Personally I have modified add_domain to always create as MASTER,
and Show quoted text
> > if
> >> need be I can afterwards make_domain_native.
> > > > Red, will you submit a patch with the new functions "add_master" and > > "make_domain_master", and test them out? Then I can add them to the > > module. --Augie > >
  Fri Aug 03 19:32:31 2012 augie.schwer [...] gmail.com - Status changed from 'open' to 'patched'
  Fri Aug 03 19:33:28 2012 augie.schwer [...] gmail.com - Correspondence added
Patch applied in v0.11 .
  Fri Aug 03 19:33:29 2012 The RT System itself - Status changed from 'patched' to 'open'
  Fri Aug 03 19:33:29 2012 augie.schwer [...] gmail.com - Status changed from 'open' to 'resolved'