Skip Menu |

This queue is for tickets about the Net-SSLeay CPAN distribution.

Report information
The Basics
Id: 76757
Status: resolved
Worked: 30 min
Priority: 0/
Queue: Net-SSLeay

People
Owner: MIKEM [...] cpan.org
Requestors: ANDK [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.47
Fixed in: (no value)



Subject: Hard coded port 1211 in test
The file t/local/06_tcpecho.t contains 13 my $port = 1211; and this port must be unused if the test should be passed because: 21 bind($sock, $serv_params) or die; Could this test not be made a bit more flexible and simply walk over a range of ports and fail only if some 1000 or so can't be bound to? And it would also be nice if the failure mode were a bit more helpful than "or die" without any error message. Thanks,
Subject: Re: [rt.cpan.org #76757] Hard coded port 1211 in test
Date: Mon, 23 Apr 2012 16:24:21 +1000
To: bug-Net-SSLeay [...] rt.cpan.org
From: Mike McCauley <mikem [...] open.com.au>
Hi, Thanks for the suggestion. Now in svn commit 341; Cheers. On Sunday, April 22, 2012 10:57:29 AM you wrote: Show quoted text
> Sun Apr 22 10:57:27 2012: Request 76757 was acted upon. > Transaction: Ticket created by ANDK > Queue: Net-SSLeay > Subject: Hard coded port 1211 in test > Broken in: 1.47 > Severity: Normal > Owner: Nobody > Requestors: ANDK@cpan.org > Status: new > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=76757 > > > > The file t/local/06_tcpecho.t contains > > 13 my $port = 1211; > > and this port must be unused if the test should be passed because: > > 21 bind($sock, $serv_params) or die; > > Could this test not be made a bit more flexible and simply walk over a > range of ports and fail only if some 1000 or so can't be bound to? > > And it would also be nice if the failure mode were a bit more helpful > than "or die" without any error message. > > Thanks,
-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.