Skip Menu |

This queue is for tickets about the Catalyst-Runtime CPAN distribution.

Report information
The Basics
Id: 76710
Status: resolved
Priority: 0/
Queue: Catalyst-Runtime

People
Owner: Nobody in particular
Requestors: troy [...] good.net
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in:
  • 5.90010
  • 5.90011
Fixed in: (no value)



Subject: Documentation incorrect wrt $c->req->secure, Catalyst::Request
At some point, the setting of $c->req->secure stopped looking at $env->{SERVER_PORT} == 443 and looked primarily at $env->{HTTPS} being set to on. Documentation patch included, but not sure if it's sufficient.
Subject: docpatch.diff
--- Request.pm-orig 2012-04-19 15:46:09.000000000 -0700 +++ Request.pm 2012-04-19 15:46:59.000000000 -0700 @@ -649,9 +649,8 @@ Returns true or false, indicating whether the connection is secure (https). Note that the URI scheme (e.g., http vs. https) must be determined through heuristics, and therefore the reliability of $req->secure will depend -on your server configuration. If you are serving secure pages on the standard -SSL port (443) and/or setting the HTTPS environment variable, $req->secure -should be valid. +on your server configuration. If you are setting the HTTPS environment variable, +$req->secure should be valid. =head2 $req->captures
Thanks, applied as commit 3a526ce, will be in the next release!