Skip Menu |

This queue is for tickets about the POE-Component-Resolver CPAN distribution.

Report information
The Basics
Id: 76549
Status: resolved
Priority: 0/
Queue: POE-Component-Resolver

People
Owner: Nobody in particular
Requestors: kozunov [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: Critical
Broken in: 0.916
Fixed in: (no value)



Subject: wrong using splice
I see in code this path twice my $i = @{$heap->{sidecar_ring}}; while ($i--) { next unless $heap->{sidecar_ring}[$i]->ID() == $wheel_id; splice(@{$heap->{sidecar_ring}}, 1, 1); last; } I think that you want to write splice(@{$heap->{sidecar_ring}}, $i, 1);
commit accbcc5a17b77642325a00267e78d1506d936640 Author: Rocco Caputo <rcaputo@cpan.org> Date: Sun Apr 29 19:22:55 2012 -0400 [rt.cpan.org 76549] Fix a little typo in sidecar cleanup. _poe_sidecar_closed() was destroying the wrong sidecar process. Thank you, Kozunov, for the code review and bug report. Two little octets can make a huge difference.