Skip Menu |

This queue is for tickets about the Net-SSH-Perl CPAN distribution.

Report information
The Basics
Id: 76482
Status: resolved
Priority: 0/
Queue: Net-SSH-Perl

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 1.34
Fixed in: (no value)



Subject: t/03-packet.t fails in bleadperl (perl 5.15.x)
The matrix overview http://matrix.cpantesters.org/?dist=Net-SSH-Perl shows that tests fail under bleadperl. A sample fail report http://www.cpantesters.org/cpan/report/7075278c-2612-11e1-b870-65a2c5c5e6fb shows the following kind of error: Can't locate object method "TIESCALAR" via package "StringThing" at t/03-packet.t line 30. # Looks like your test exited with 255 before it could output anything. t/03-packet.t ...... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/10 subtests The only PASSes happen because this test is skipped if Math::GMP is installed. Regards, Slaven
On Tue Apr 10 16:35:32 2012, SREZIC wrote: Show quoted text
> The matrix overview http://matrix.cpantesters.org/?dist=Net-SSH-Perl > shows that tests fail under bleadperl. A sample fail report > http://www.cpantesters.org/cpan/report/7075278c-2612-11e1-b870-65a2c5c5e6fb > shows the following kind of error: > > Can't locate object method "TIESCALAR" via package "StringThing" at > t/03-packet.t line 30. > # Looks like your test exited with 255 before it could output anything. > t/03-packet.t ...... > Dubious, test returned 255 (wstat 65280, 0xff00) > Failed 10/10 subtests > > The only PASSes happen because this test is skipped if Math::GMP is > installed.
In this code in t/03-packet.t: ## Okay, so you shouldn't ever be doing this, ## in real usage; override the socket with a ## special tied filehandle. my $fh = do { local *FH; *FH }; tie $fh, 'StringThing'; $ssh->{session}{sock} = $fh; tie $fh should be tie *$fh, with an explicit asterisk. I can’t get Crypt::DH, which is in the list of dependencies, to install, so I cannot test it.
Test also fails with perl 5.16.0 RC0. Regards, Slaven
On Sat May 12 10:11:23 2012, SREZIC wrote: Show quoted text
> Test also fails with perl 5.16.0 RC0.
And, unsurprisingly, with 5.16.0 'real': Running make test PERL_DL_NONLAZY=1 /disk/jkns/workspace/perl-5.16/build/tmp/perl-nap-5.16.0- 2012.08.02.8.gc8d6af1-build/opt/xt/xt-perl/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-signature.t ... skipped: Set the environment variable TEST_SIGNATURE to enable this test t/01-compile.t ..... ok t/02-buffer.t ...... ok Can't locate object method "TIESCALAR" via package "StringThing" at t/03-packet.t line 30. # Looks like your test exited with 255 before it could output anything. t/03-packet.t ...... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/10 subtests t/04-config.t ...... ok t/05-cipher.t ...... ok t/06-auth.t ........ skipped: Test not enabled yet t/06-circular.t .... ok t/99-perlcritic.t .. skipped: Set the environment variable TEST_CRITIC to enable this test t/99-pod.t ......... skipped: Test not ready yet. t/99-spellcheck.t .. skipped: Set the environment variable TEST_SPELL to enable this test t/99-yaml.t ........ skipped: Set the environment variable TEST_AUTHOR to enable this test
Sending the previous mail has failed. Please contact your admin, they can find more details in the logs.
Sending the previous mail has failed. Please contact your admin, they can find more details in the logs.
Sending the previous mail has failed. Please contact your admin, they can find more details in the logs.
Sending the previous mail has failed. Please contact your admin, they can find more details in the logs.
On Sat May 12 10:11:23 2012, SREZIC wrote: Show quoted text
> Test also fails with perl 5.16.0 RC0.
And, unsurprisingly, with 5.16.0 'real': Running make test PERL_DL_NONLAZY=1 /disk/jkns/workspace/perl-5.16/build/tmp/perl-nap-5.16.0- 2012.08.02.8.gc8d6af1-build/opt/xt/xt-perl/bin/perl "-MExtUtils::Command::MM" "-e" "test_harness(0, 'blib/lib', 'blib/arch')" t/*.t t/00-signature.t ... skipped: Set the environment variable TEST_SIGNATURE to enable this test t/01-compile.t ..... ok t/02-buffer.t ...... ok Can't locate object method "TIESCALAR" via package "StringThing" at t/03-packet.t line 30. # Looks like your test exited with 255 before it could output anything. t/03-packet.t ...... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 10/10 subtests t/04-config.t ...... ok t/05-cipher.t ...... ok t/06-auth.t ........ skipped: Test not enabled yet t/06-circular.t .... ok t/99-perlcritic.t .. skipped: Set the environment variable TEST_CRITIC to enable this test t/99-pod.t ......... skipped: Test not ready yet. t/99-spellcheck.t .. skipped: Set the environment variable TEST_SPELL to enable this test t/99-yaml.t ........ skipped: Set the environment variable TEST_AUTHOR to enable this test
Sending the previous mail has failed. Please contact your admin, they can find more details in the logs.
The previous idea (*$fh) worked and allowed me to build a full perl+cpan-modules RPM
Subject: Net-SSH-Perl-1.34--perl5.16.patch
--- t/03-packet.t-orig 2012-05-22 14:37:48.000000000 +0100 +++ t/03-packet.t 2012-05-22 14:37:08.000000000 +0100 @@ -27,7 +27,7 @@ ## in real usage; override the socket with a ## special tied filehandle. my $fh = do { local *FH; *FH }; -tie $fh, 'StringThing'; +tie *$fh, 'StringThing'; $ssh->{session}{sock} = $fh; {
Sending the previous mail has failed. Please contact your admin, they can find more details in the logs.
Sending the previous mail has failed. Please contact your admin, they can find more details in the logs.
On Tue May 22 11:11:58 2012, CHISEL wrote: Show quoted text
> The previous idea (*$fh) worked and allowed me to build a full > perl+cpan-modules RPM
Patch applied, v1.35 just uploaded, thanks. Steffen -- Steffen Schwigon <ss5@renormalist.net> Dresden Perl Mongers <http://dresden-pm.org/>