Skip Menu |

This queue is for tickets about the Module-CPANTS-Analyse CPAN distribution.

Report information
The Basics
Id: 76467
Status: resolved
Priority: 0/
Queue: Module-CPANTS-Analyse
People
Owner: Nobody in particular
Requestors: ribasushi [...] leporine.io
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)

History Show all quoted text
  Tue Apr 10 09:36:07 2012 ribasushi [...] leporine.io - Ticket created
Subject: Incorrect "no podcoverage" metric
http://cpants.charsbar.org/dist/kwalitee/DBIx-Class complains about 0.08196 failing has_test_pod and has_test_pod_coverage. However: https://metacpan.org/source/ARODLAND/DBIx-Class-0.08196/xt/pod.t https://metacpan.org/source/ARODLAND/DBIx-Class-0.08196/xt/podcoverage.t Cheers
  Tue Apr 10 12:53:03 2012 dolmen [...] cpan.org - Correspondence added
Le 2012-04-10 15:36:07, RIBASUSHI a écrit : Show quoted text
> http://cpants.charsbar.org/dist/kwalitee/DBIx-Class complains about > 0.08196 failing has_test_pod and has_test_pod_coverage. However: > https://metacpan.org/source/ARODLAND/DBIx-Class-0.08196/xt/pod.t > https://metacpan.org/source/ARODLAND/DBIx-Class-0.08196/xt/podcoverage.t > > Cheers
If you really want this to be fixed, you'll have to provide a patch, or better, fix your code. Detecting your usage of Test::Pod::Coverage with pure static analysis of this code seems quite impossible. Here is a more conventional way of testing POD coverage that is correctly analyzed by the metric: https://metacpan.org/source/DOLMEN/ARGV-URL-0.93/t/91-pod-coverage.t -- Olivier Mengué - http://perlresume.org/DOLMEN
  Tue Apr 10 12:53:04 2012 The RT System itself - Status changed from 'new' to 'open'
  Sat Feb 16 12:16:20 2013 ribasushi [...] leporine.io - Correspondence added
On Tue Apr 10 12:53:03 2012, DOLMEN wrote: Show quoted text
> Le 2012-04-10 15:36:07, RIBASUSHI a écrit :
> > http://cpants.charsbar.org/dist/kwalitee/DBIx-Class complains about > > 0.08196 failing has_test_pod and has_test_pod_coverage. However: > > https://metacpan.org/source/ARODLAND/DBIx-Class-0.08196/xt/pod.t > > https://metacpan.org/source/ARODLAND/DBIx-Class-0.08196/xt/podcoverage.t > > > > Cheers
> > If you really want this to be fixed, you'll have to provide a patch, or > better, fix your code. > Detecting your usage of Test::Pod::Coverage with pure static analysis of > this code seems quite impossible.
Yes, that's a good point. I looked at how you do it and it seems that all I need to do is satisfy Module::ExtractUse. But my changes [1] still do not seem to satisfy CPANTS [2]. Do I *really* have to 'use Test::Pod' to get this to work? Seems suboptimal (I will do it if this is the only way forward, and wrap the checks in a BEGIN, but meh). [1] https://github.com/dbsrgits/dbix-class/commit/f7ed0ed3 [2] http://cpants.cpanauthors.org/dist/DBIx-Class-0.08240-TRIAL
  Sat Feb 23 11:11:39 2013 ribasushi [...] leporine.io - Dependency on ticket #83569 added
  Sat Feb 23 11:13:35 2013 ribasushi [...] leporine.io - Correspondence added
Show quoted text
> I looked at how you do it and it seems that > all I need to do is satisfy Module::ExtractUse. > But my changes still do not seem to satisfy CPANTS.
That's because Module::ExtractUse is broken :( I filed and linked a minimal reproducible example: https://rt.cpan.org/Public/Bug/Display.html?id=83569
  Mon Feb 25 16:52:44 2013 ribasushi [...] leporine.io - Correspondence added
A new bugfixed Module::ExtractUse just hit CPAN. Please upgrade when time permits and close this ticket. Cheers
  Sat Aug 03 09:56:30 2013 ishigaki [...] cpan.org - Correspondence added
Thanks. This has been done for a while. Closed as resolved. On Tue Feb 26 06:52:44 2013, RIBASUSHI wrote: Show quoted text
> A new bugfixed Module::ExtractUse just hit CPAN. Please upgrade when > time permits and close this ticket. > > Cheers
  Sat Aug 03 09:56:30 2013 ishigaki [...] cpan.org - Status changed from 'open' to 'resolved'