Skip Menu |

This queue is for tickets about the PerlIO-gzip CPAN distribution.

Report information
The Basics
Id: 76335
Status: patched
Priority: 0/
Queue: PerlIO-gzip

People
Owner: Nobody in particular
Requestors: SREZIC [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in:
  • 0.18
  • 0.19
Fixed in: (no value)



Subject: Mismatched number of skipped tests
On systems without a gzip command available (e.g. stock Windows) the read.t test fails because the number of skipped tests is off by one. The attached patch fixes the problem. Regards, Slaven
Subject: 0001-fixed-number-of-skipped-tests.patch
From 59c438c4c992fd8b9b754dcde0158f1ecedcf1c6 Mon Sep 17 00:00:00 2001 From: Slaven Rezic <slaven@rezic.de> Date: Thu, 5 Apr 2012 22:02:54 +0200 Subject: [PATCH] fixed number of skipped tests --- t/read.t | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) mode change 100644 => 100755 t/read.t diff --git a/t/read.t b/t/read.t old mode 100644 new mode 100755 index ab4f6a7..330372f --- a/t/read.t +++ b/t/read.t @@ -132,7 +132,7 @@ foreach my $buffering ('', ':unix', ':stdio', ':perlio') { $done_perlgz = system $command; } SKIP: { - skip "$command failed", 3 if $done_perlgz; + skip "$command failed", 4 if $done_perlgz; ok ((open GZ, "<$buffering:gzip", "perl.gz"), "open perl.gz"); TODO: { # local $TODO = $unread_bug if $buffering eq ':unix'; -- 1.7.0.4
Same problem in 0.19. -- Alexandr Ciornii, http://chorny.net
On Thu Apr 05 16:07:18 2012, SREZIC wrote: Show quoted text
> On systems without a gzip command available (e.g. stock Windows) the > read.t test fails because the number of skipped tests is off by one. The > attached patch fixes the problem.
Thanks, now applied, and 0.20 uploaded to CPAN. Really this should have been part of 0.19, but I missed that it was obvious "low hanging fruit". Nicholas Clark