Skip Menu |

This queue is for tickets about the XML-LibXSLT CPAN distribution.

Report information
The Basics
Id: 761
Status: resolved
Priority: 0/
Queue: XML-LibXSLT

People
Owner: Nobody in particular
Requestors: mtardif [...] sitepak.com
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.50
Fixed in: (no value)



Subject: xpath_to_string appends needless single quote
xpath_to_string appends a single quote to strings containing a single quote. Please apply the following patch for the next release: --- XML-LibXSLT-1.50.old/LibXSLT.pm Thu May 23 09:23:45 2002 +++ XML-LibXSLT-1.50.new/LibXSLT.pm Tue Jun 18 17:53:23 2002 @@ -30,13 +30,8 @@ my $value = shift(@_); $value = '' unless defined $value; push @results, $value; next if @results % 2; - if ($value =~ /\'/) { - $results[-1] = join('', - "concat(", - join(', ', - map { "'$_', \"'\"" } - split /\'/, $value), - ")"); + if ($value =~ s/'/', "'", '/g) { + $results[-1] = "concat('$value')"; } else { $results[-1] = "'$results[-1]'";
patch already applied, just closing