Skip Menu |

This queue is for tickets about the Test-EOL CPAN distribution.

Report information
The Basics
Id: 75968
Status: resolved
Priority: 0/
Queue: Test-EOL

People
Owner: bobtfish [...] bobtfish.net
Requestors: MAXS [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Important
Broken in: 1.1
Fixed in: (no value)



Subject: Bad regex to match subversion directories
The module does not work if in the parent directories hierarchy a directory is named /svn/... The patch correct this bug. Best regards, Max.
Subject: EOL.patch
--- lib/Test/EOL.pm.orig 2012-03-22 11:55:26.000000000 +0100 +++ lib/Test/EOL.pm 2012-03-22 11:55:39.000000000 +0100 @@ -51,7 +51,7 @@ my @base_dirs = @_ ? @_ : File::Spec->catdir($Bin, $updir); my @found; my $want_sub = sub { - return if ($File::Find::dir =~ m![\\/]?CVS[\\/]|[\\/]?.svn[\\/]!); # Filter out cvs or subversion dirs/ + return if ($File::Find::dir =~ m![\\/]?CVS[\\/]|[\\/]?\.svn[\\/]!); # Filter out cvs or subversion dirs/ return if ($File::Find::dir =~ m![\\/]?blib[\\/]libdoc$!); # Filter out pod doc in dist return if ($File::Find::dir =~ m![\\/]?blib[\\/]man\d$!); # Filter out pod doc in dist return if ($File::Find::name =~ m!Build$!i); # Filter out autogenerated Build script
Fixed in git: e52debaf9531a474e8e01ca753d308975c4804a8 Will be in the next release. Thanks for the bug report!