Bug #75954 for IO-Async: Unable to construct IO::Async::Timer::Countdown with delay==0

Wed Mar 21 17:12:56 2012 leonerd-cpan [...] leonerd.org.uk - Ticket created

Subject:

Unable to construct IO::Async::Timer::Countdown with delay==0

$ perl -MIO::Async::Timer::Countdown \ -E 'IO::Async::Timer::Countdown->new( delay => 0, on_expire => sub {} ) Expected a 'delay' as a positive number at -e line 1 This can be a useful thing to do, to achieve a "later"-like ability. -- Paul Evans

Wed Mar 21 18:20:18 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Fixed. -- Paul Evans

Subject:

rt75954.patch

=== modified file 'lib/IO/Async/Timer/Countdown.pm' --- lib/IO/Async/Timer/Countdown.pm 2012-03-21 12:43:18 +0000 +++ lib/IO/Async/Timer/Countdown.pm 2012-03-21 21:56:21 +0000 @@ -1,7 +1,7 @@ # You may distribute under the terms of either the GNU General Public License # or the Artistic License (the same terms as Perl itself) # -# (C) Paul Evans, 2009-2011 -- leonerd@leonerd.org.uk +# (C) Paul Evans, 2009-2012 -- leonerd@leonerd.org.uk package IO::Async::Timer::Countdown; @@ -77,7 +77,8 @@ =item delay => NUM The delay in seconds after starting the timer until it expires. Cannot be -changed if the timer is running. +changed if the timer is running. A timer with a zero delay expires +"immediately". =item remove_on_expire => BOOL @@ -112,7 +113,7 @@ $self->is_running and croak "Cannot configure 'delay' of a running timer\n"; my $delay = delete $params{delay}; - $delay > 0 or croak "Expected a 'delay' as a positive number"; + $delay >= 0 or croak "Expected a 'delay' as a non-negative number"; $self->{delay} = $delay; }

Wed Mar 21 18:20:18 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'patched'

Thu Mar 22 05:59:07 2012 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.46_002 added

Sun Mar 25 11:37:11 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'

Sun Mar 25 11:37:11 2012 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.47 added