Bug #75935 for Net-SSLeay: Fix for SSL_get_shared

Wed Mar 21 04:55:04 2012 kmx [...] volny.cz - Ticket created

Subject:	Fix for SSL_get_shared_ciphers
Date:	Wed, 21 Mar 2012 09:54:52 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Fixing crazy calling convention for Net::SSLeay::get_shared_ciphers() which IMHO never worked correctly. $rv = SSL_get_shared_ciphers($ssl, $buf, length($buf)); to $rv = SSL_get_shared_ciphers($ssl); For backward compatibility the second and the third parameters are still accepted but ignored Also added test for this + documentation patch -- kmx

Message body is not shown because sender requested not to inline it.

Wed Mar 21 08:33:11 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75935] Fix for SSL_get_shared_ciphers
Date:	Wed, 21 Mar 2012 13:33:00 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

Just updated diff against rev322

Message body is not shown because sender requested not to inline it.

Wed Mar 21 08:48:05 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75935] Fix for SSL_get_shared_ciphers
Date:	Wed, 21 Mar 2012 22:47:04 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

Hi, I get compile errors on Windows (but not Linux!) from this patch unless SSLeay.pm line 1425 is PREINIT not INIT On Wednesday, March 21, 2012 08:33:11 AM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75935 > > > Just updated diff against rev322

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Wed Mar 21 08:48:07 2012 The RT System itself - Status changed from 'new' to 'open'

Wed Mar 21 08:51:13 2012 kmx [...] volny.cz - Correspondence added

Subject:	Re: [rt.cpan.org #75935] Fix for SSL_get_shared_ciphers
Date:	Wed, 21 Mar 2012 13:51:02 +0100
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	kmx <kmx [...] volny.cz>

On 21.3.2012 13:48, mikem@open.com.au via RT wrote: Show quoted text

> <URL: https://rt.cpan.org/Ticket/Display.html?id=75935> > > Hi, > > I get compile errors on Windows (but not Linux!) from this patch unless > SSLeay.pm line 1425 is > > PREINIT > not > INIT >

Yes, sorry PREINIT is correct (it is due to using default values ignored_param1=0,ignored_param2=0) -- kmx

Thu Mar 22 01:51:29 2012 mikem [...] open.com.au - Correspondence added

Subject:	Re: [rt.cpan.org #75935] Fix for SSL_get_shared_ciphers
Date:	Fri, 23 Mar 2012 15:50:24 +1000
To:	bug-Net-SSLeay [...] rt.cpan.org
From:	Mike McCauley <mikem [...] open.com.au>

On Wednesday, March 21, 2012 08:51:13 AM you wrote: Show quoted text

> Queue: Net-SSLeay > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75935 > > > On 21.3.2012 13:48, mikem@open.com.au via RT wrote:

> > <URL: https://rt.cpan.org/Ticket/Display.html?id=75935> > > > > Hi, > > > > I get compile errors on Windows (but not Linux!) from this patch unless > > SSLeay.pm line 1425 is > > > > PREINIT > > not > > INIT

> > Yes, sorry PREINIT is correct (it is due to using default values > ignored_param1=0,ignored_param2=0)

OK, committed at 323 Cheers. Show quoted text

> > -- > kmx

-- Mike McCauley mikem@open.com.au Open System Consultants Pty. Ltd 9 Bulbul Place Currumbin Waters QLD 4223 Australia http://www.open.com.au Phone +61 7 5598-7474 Fax +61 7 5598-7070 Radiator: the most portable, flexible and configurable RADIUS server anywhere. SQL, proxy, DBM, files, LDAP, NIS+, password, NT, Emerald, Platypus, Freeside, TACACS+, PAM, external, Active Directory, EAP, TLS, TTLS, PEAP, TNC, WiMAX, RSA, Vasco, Yubikey, MOTP, HOTP, TOTP, DIAMETER etc. Full source on Unix, Windows, MacOSX, Solaris, VMS, NetWare etc.

Thu Mar 22 17:29:58 2012 MIKEM [...] cpan.org - Status changed from 'open' to 'resolved'

Thu Mar 22 17:29:59 2012 MIKEM [...] cpan.org - Given to MIKEM

Bug #75935 for Net-SSLeay: Fix for SSL_get_shared_ciphers