Skip Menu |

This queue is for tickets about the Data-Serializer CPAN distribution.

Report information
The Basics
Id: 75850
Status: resolved
Priority: 0/
Queue: Data-Serializer

People
Owner: Nobody in particular
Requestors: xenoterracide [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: kwalitee doesn't pass and causes make test to fail
Date: Sat, 17 Mar 2012 19:52:34 -0500
To: bugs-data-serializer [...] rt.cpan.org
From: Caleb Cushing <xenoterracide [...] gmail.com>
I've attached a git patch that essentially uses Test::Requires to do the eval that was being done, as it's intended for this. It also use Test::Requires::Env to ensure that this test is only run for Authors. patch -p1 < ~/0001-use-Test-Requires-Env-to-test-runtest-requirements.patch t/00-02-Kwalitee.t .. 1..13 ok 1 - extractable ok 2 - has_readme ok 3 - has_manifest ok 4 - has_meta_yml ok 5 - has_buildtool ok 6 - has_changelog ok 7 - no_symlinks ok 8 - has_tests ok 9 - proper_libs ok 10 - no_pod_errors ok 11 - use_strict not ok 12 - has_test_pod not ok 13 - has_test_pod_coverage # Failed test 'has_test_pod' # at /home/xenoterracide/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Test/Kwalitee.pm line 101. # Add a test using Test::Pod to check for pod correctness.Doesn't include a test for pod correctness (Test::Pod) # Failed test 'has_test_pod_coverage' # at /home/xenoterracide/perl5/perlbrew/perls/perl-5.14.2/lib/site_perl/5.14.2/Test/Kwalitee.pm line 101. # Add a test using Test::Pod::Coverage to check for POD coverage.Doesn't include a test for pod coverage (Test::Pod::Coverage) # Looks like you failed 2 tests of 13. Dubious, test returned 2 (wstat 512, 0x200) Failed 2/13 subtests Test Summary Report ------------------- t/00-02-Kwalitee.t (Wstat: 512 Tests: 13 Failed: 2) Failed tests: 12-13 Non-zero exit status: 2 Files=1, Tests=13, 2 wallclock secs ( 0.03 usr 0.01 sys + 0.84 cusr 0.04 csys = 0.92 CP Result: FAIL -- Caleb Cushing http://xenoterracide.com

Message body is not shown because sender requested not to inline it.

Wow, I let this sit around far too long - sorry about that. I just released 0.60 which takes a more brutish approach to solving that problem - specifically moving the kwalitee test (and a couple others) out of t/ into xt/ as they really aren't important for operation of the module at all. Thanks for catching the error.