Bug #75731 for Catalyst-Runtime: $c->req->hostname is empty for an ipv6-client

Tue Mar 13 06:03:22 2012 trond [...] thaugen.no - Ticket created

Subject:

$c->req->hostname is empty for an ipv6-client

Catalyst::Request seems to call gethostbyaddr to determine the hostname of a calling client. This works OK for ipv4 clients, but I have problems using a ipv6 client, in which case the $c->req->hostname becomes undef. A bit of googling tells me that some adaptions may be needed for IPV6: http://long.ccaba.upc.es/long/045Guidelines/eva/ipv6.html Perhaps you could try to use of the new 'getaddrinfo' and 'getnameinfo' to be more portable?

Tue Mar 13 18:02:57 2012 bobtfish [...] bobtfish.net - Correspondence added

On Tue Mar 13 06:03:22 2012, TROHAU wrote: Show quoted text

> Catalyst::Request seems to call gethostbyaddr to determine the hostname > of a calling client. This works OK for ipv4 clients, but I have problems > using a ipv6 client, in which case the $c->req->hostname becomes undef. > > A bit of googling tells me that some adaptions may be needed for IPV6: > http://long.ccaba.upc.es/long/045Guidelines/eva/ipv6.html > > Perhaps you could try to use of the new 'getaddrinfo' and 'getnameinfo' > to be more portable?

You're entirely correct here. A patch to fix this would be welcome :)

Tue Mar 13 18:03:00 2012 The RT System itself - Status changed from 'new' to 'open'

Mon Jan 18 08:04:33 2016 abraxxa [...] cpan.org - Correspondence added

A proposed patch is now in the branch bugs/rt-75731. Please review and merge.

Mon Sep 12 15:18:32 2016 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Mon Jan 18 08:04:33 2016, ABRAXXA wrote: Show quoted text

> A proposed patch is now in the branch bugs/rt-75731. > Please review and merge.

So I believe I $ git clone git://git.shadowcat.co.uk/catagits/Catalyst-Runtime.git $ git checkout bugs/rt-75731 $ git diff master...HEAD Reviewing now... -- Paul Evans

Mon Sep 12 16:16:14 2016 leonerd-cpan [...] leonerd.org.uk - Correspondence added

On Mon Sep 12 15:18:32 2016, PEVANS wrote: Show quoted text

> Reviewing now...

Hm. First comment: Why NI_DGRAM? I believe this is a TCP socket, not a UDP one. Also, that won't have any effect on the hostname result; it's there only to distinguish between some services that differ between UDP and TCP (e.g. some Windows netbios-related things). -- Paul Evans

Mon Sep 12 16:44:18 2016 leonerd-cpan [...] leonerd.org.uk - Correspondence added

Ah, also: the NIx_NOSERV flag is a flag for the separate $xflags argument; it's an extension on top of the normal C-level flags argument. -- Paul Evans

Mon Jan 23 06:22:23 2017 abraxxa [...] cpan.org - Correspondence added

The branch includes all fixes which we discussed on IRC, please review and comment if it can be merged to master as is, thanks!

Wed Nov 28 05:20:39 2018 haarg [...] haarg.org - Correspondence added

Fixed in 5.90123

Wed Nov 28 05:20:40 2018 haarg [...] haarg.org - Status changed from 'open' to 'resolved'

Wed Nov 28 05:20:40 2018 haarg [...] haarg.org - Fixed in 5.90123 added