Subject: | When using a cache, is_success() should return true on a 304 |
When using a cache, if you get a 304 response, the response from fetch() signifies failure (i.e.
is_success() returns false), and you have to write code like this:
if ($response->is_success || $response->http_status == 304)
Given the nature of the module, if you're caching, and get a 304 response, then given that the
response from fetch() includes content, then I think is_success() should return true. Then you
can just write:
if ($response->is_success) {
# process response->content
} else {
# bugger!
}