Skip Menu |

This queue is for tickets about the Device-Gsm CPAN distribution.

Report information
The Basics
Id: 75619
Status: resolved
Worked: 1 hour (60 min)
Priority: 0/
Queue: Device-Gsm

People
Owner: cosimo [...] cpan.org
Requestors: debian.axhn [...] manchmal.in-ulm.de
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: (no value)



Subject: [PATCH] Please fix POD errors
Date: Thu, 8 Mar 2012 08:03:45 +0100
To: bug-Device-Gsm [...] rt.cpan.org
From: Christoph Biedl <debian.axhn [...] manchmal.in-ulm.de>
(minor severity) Hello, while packaging Device::GSM 1.58 for the Debian Linux distribution I noticed two pod errors. See the patch below. Cheers, Christoph From: Christoph Biedl <debian.axhn@manchmal.in-ulm.de> Subject: Patch: Fix pod errors Date: Wed, 7 Mar 2012 22:41:12 +0100 diff --git a/Gsm.pm b/Gsm.pm index 8e3378b..125d082 100644 --- a/Gsm.pm +++ b/Gsm.pm @@ -1306,7 +1306,7 @@ Send out an SMS message quickly: The allowed parameters to send_sms() are: -=over - +=over =item C<class> diff --git a/lib/Device/Gsm/Sms.pm b/lib/Device/Gsm/Sms.pm index 1242bf4..8d9ef95 100644 --- a/lib/Device/Gsm/Sms.pm +++ b/lib/Device/Gsm/Sms.pm @@ -241,13 +241,13 @@ sub decode { my $mti = $token->MTI(); -=cut - # If MTI has bit 1 on, this could be a SMS-STATUS message (0x02), or (0x03???) - if( $mti >= SMS_STATUS ) { - _log('skipping unhandled message type ['.$mti.']'); - return undef; - } -=cut +#=cut +# # If MTI has bit 1 on, this could be a SMS-STATUS message (0x02), or (0x03???) +# if( $mti >= SMS_STATUS ) { +# _log('skipping unhandled message type ['.$mti.']'); +# return undef; +# } +#=cut if( $mti != $type ) { #_log('token PDUTYPE, data='.$token->data().' MTI='.$token->get('MTI').' ->MTI()='.$token->MTI());
Download signature.asc
application/pgp-signature 198b

Message body not shown because it is not plain text.

On Thu Mar 08 02:04:02 2012, debian.axhn@manchmal.in-ulm.de wrote: Show quoted text
> > while packaging Device::GSM 1.58 for the Debian Linux distribution I > noticed two pod errors. See the patch below.
Thanks much for the feedback! I plan to have 1.59 on CPAN and include these two fixes, plus a minor fix to have Device::Gsm test cleanly under perl 5.15. -- Cosimo
I've pushed Device::Gsm 1.59, that includes these POD fixes and other changes to CPAN. I've also changed the location of Gsm.pm to be the standard lib/Device/ Gsm.pm.
Subject: Re: [rt.cpan.org #75619] [PATCH] Please fix POD errors
Date: Sun, 11 Mar 2012 11:16:44 +0100
To: Cosimo Streppone via RT <bug-Device-Gsm [...] rt.cpan.org>
From: Christoph Biedl <debian.axhn [...] manchmal.in-ulm.de>
Cosimo Streppone via RT wrote... Show quoted text
> I've pushed Device::Gsm 1.59, that includes these POD fixes and other > changes to CPAN.
Ah, agile upstream. Much appreciated. Just a note, I will intentionally postpone the upload of 1.59 to Debian by about a week to make sure version 1.58 hits the testing archive first. Cheers, Christoph
Was resolved long time ago.