Bug #75596 for Log-Handler: %s placeholder

On Tue Mar 06 20:51:07 2012, http://dr1024.myopenid.com/ wrote: Show quoted text
No. Log::Handler returns what caller returns. --- use strict; use warnings; use Data::Dumper; sub foo { print Dumper([ caller(0) ]); } my $bar = sub { print Dumper([ caller(0) ]); }; &foo(); &$bar(); --- $VAR1 = [ 'main', 'test.pl', 14, 'main::foo', 1, undef, undef, undef, 1794, 'UUUUUUUUUUU', undef ]; $VAR1 = [ 'main', 'test.pl', 15, 'main::__ANON__', 1, undef, undef, undef, 1794, 'UUUUUUUUUUU', undef ];

Unfortunately that is not possible. Let me explain it: --- use Log::Handler; $Log::Handler::CALLER_LEVEL = 1; my $log = Log::Handler->new(); $log->add(screen => { message_layout => '%m %s', debug_trace => 1 }); $log->warn("foo"); --- Output: Use of uninitialized value in concatenation (.) or string at (eval 8) line 1. foo CALL(2): package(main) filename(test.pl) line(8) subroutine (Log::Handler::Levels::__ANON__) hasargs(1) CALL(1): package(Log::Handler::Levels) filename(/usr/local/share/ perl/5.10.1/Log/Handler/Levels.pm) line(212) subroutine (Log::Handler::Output::log) hasargs(1) wantarray(0) CALL(0): package(Log::Handler::Output) filename(/usr/local/share/ perl/5.10.1/Log/Handler/Output.pm) line(96) subroutine (Log::Handler::Output::_add_trace) hasargs(1) You can see here that just "foo" is printed, but not the subroutine or line number, because caller level 3 does not exists. Next example: --- use Log::Handler; $Log::Handler::CALLER_LEVEL = 1; my $log = Log::Handler->new(); $log->add(screen => { message_layout => '%m %s line %l' }); &foo; sub foo { $log->warn("foo"); $log->warn("bar"); $log->warn("baz"); } --- Output: foo main::foo line 8 bar main::foo line 8 baz main::foo line 8 I don't think that this way of debugging is the right way. We just see every time the same line number. If the package or subroutine is very large then I want to see on which line the logger was called and not which subroutine above called the logger. If you want that, then please set CALLER_LEVEL to 1. $Log::Handler::CALLER_LEVEL = 1; Cheers, Jonny

I think both your examples above work ok with the patch I suggested. As you say, calling $log->warn outside any subroutine (as in your first example) would cause an issue with %s, hence catch that case with //"" (as in the patch). Only _get_c_sub needs any change (globally raising CALLER_LEVEL is not the solution). Thanks, David On Wed Mar 07 11:32:43 2012, BLOONIX wrote: Show quoted text

see 0.73