Skip Menu |

This queue is for tickets about the IO-Async CPAN distribution.

Report information
The Basics
Id: 75573
Status: resolved
Priority: 0/
Queue: IO-Async
People
Owner: Nobody in particular
Requestors: leonerd-cpan [...] leonerd.org.uk
Cc:
AdminCc:
Bug Information
Severity: Important
Broken in: 0.46
Fixed in:
  • 0.46_002
  • 0.47

History Show all quoted text
  Tue Mar 06 07:11:57 2012 leonerd-cpan [...] leonerd.org.uk - Ticket created
Subject: t/33process.t often fails
Appears to randomly fail on about half the cpantesters reports. May be a race condition, or some platform setup. http://www.cpantesters.org/cpan/report/05629ef6-6709-11e1-9d6f- f6dbfa7543f5 Doesn't appear to be OS-specific. -- Paul Evans
  Tue Mar 06 07:13:52 2012 leonerd-cpan [...] leonerd.org.uk - Severity Important added
  Mon Mar 12 11:43:16 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added
On Tue Mar 06 07:11:57 2012, PEVANS wrote: Show quoted text
> Appears to randomly fail on about half the cpantesters reports. May be a > race condition, or some platform setup.
Indeed a race. Should kill() parent from _inside_ the eval block. -- Paul Evans
Subject: rt75573.patch
=== modified file 't/33process.t' --- t/33process.t 2012-02-21 23:32:16 +0000 +++ t/33process.t 2012-03-12 15:42:17 +0000 @@ -212,9 +212,11 @@ my $process = IO::Async::Process->new( code => sub { my $exitcode = 10; - $SIG{TERM} = sub { $exitcode = 20; die }; - kill SIGUSR1 => $parentpid; - eval { <STDIN> }; # block + eval { + local $SIG{TERM} = sub { $exitcode = 20; die }; + kill SIGUSR1 => $parentpid; + <STDIN>; # block on signal + }; return $exitcode; }, on_finish => sub { },
  Mon Mar 12 11:43:17 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'patched'
  Tue Mar 13 04:17:29 2012 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.46_001 added
  Wed Mar 14 07:33:24 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added
This appears to be fixed according to smoke results. -- Paul Evans
  Wed Mar 14 07:33:26 2012 The RT System itself - Status changed from 'patched' to 'open'
  Sun Mar 18 09:53:49 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added
Actually, no. Still fails. A new fix is committed; will be in 0.46_002 -- Paul Evans
  Sun Mar 18 09:54:09 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'patched'
  Sun Mar 25 11:37:38 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'patched' to 'resolved'
  Sun Mar 25 11:37:38 2012 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.46_002 added
  Sun Mar 25 11:37:38 2012 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.47 added
  Sun Mar 25 11:37:38 2012 leonerd-cpan [...] leonerd.org.uk - Fixed in 0.46_001 deleted