Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the SVN-Hooks CPAN distribution.

Report information
The Basics
Id: 75547
Status: resolved
Priority: 0/
Queue: SVN-Hooks

People
Owner: GNUSTAVO [...] cpan.org
Requestors: mbrimer [...] aptina.com
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.12
Fixed in: (no value)



Subject: Failed test 'cry pre-unlock' on Windows
Dear Maintainers, I am trying to install SVN-Hooks-1.12 on Windows XP Pro SP3 with Subversion server 1.7.3 and ActivePerl 5.8.8 build 822 (replica of company server environment). Using CPAN (see attached cpan.log file), the SVN-Hooks tests fail whilst trying to lock a file as a pre-cursor to triggering the pre-unlock hook. I think that this is because the Windows version of the hook cmd files generated by test-functions.pl do not have the echo turned off and therefore the "svn lock" commands misinterprets the command line echo as a lock token (which according to the manual, the user is allowed to provide on STDIN for this command). I've attached a patch file which changes all the Windows hook cmd files to turn off the echo and then the tests pass and the module will install (providing SVN-Look has been patched and installed as per rt.cpan.org #75545 and rt.cpan.org #75546). Please could you take a look. I would really like to take advantage of both SVN-Look and SVN-Hooks on our company Subversion server. Kind Regards, Mike Brimer
Subject: cpan.log
Download cpan.log
application/octet-stream 7.9k

Message body not shown because it is not plain text.

Subject: test-functions.pl.patch
--- test-functions.pl.orig Sun Feb 26 01:34:52 2012 +++ test-functions.pl Mon Mar 05 12:42:15 2012 @@ -146,6 +146,7 @@ $hookfile .= '.cmd'; open my $fd, '>', $hookfile or die "Can't create $hookfile: $!"; + print $fd "\@echo off\n"; print $fd "$^X $hookscript $hook %1 %2 %3 %4 %5\n"; close $fd; chmod 0755 => $hookfile;
Thank you Mike. I've just released SVN::Hooks 1.13 fixing this issue. It should appear shortly on CPAN. Can you give it a try and let me know how it goes?
From: mbrimer [...] aptina.com
Hi Gustavo, Yes, that fixed it. FYI, I noticed that the added line still has a "+" marker on it. Maybe from the patch source? Doesn't seem to affect the tests though, but just thought I'd let you know. Thanks for the excellent service, Mike.
Subject: Re: [rt.cpan.org #75547] Failed test 'cry pre-unlock' on Windows
Date: Tue, 6 Mar 2012 09:13:29 -0300
To: bug-SVN-Hooks [...] rt.cpan.org
From: Gustavo Leite de Mendonça Chaves <gnustavo [...] cpan.org>
2012/3/6 Mike Brimer via RT <bug-SVN-Hooks@rt.cpan.org> Show quoted text
> Queue: SVN-Hooks > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75547 > > > Hi Gustavo, > > Yes, that fixed it. > > FYI, I noticed that the added line still has a "+" marker on it. Maybe > from the patch source? Doesn't seem to affect the tests though, but > just thought I'd let you know.
Ugh! That was ugly. Sorry. :-) Since this plus sign doesn't affect the results I'm not going to release a new version just yet. But it will be taken off in the next regular release. Thanks for the hint. Gustavo.
Fixed in v1.13.