| Subject: | List form of pipe open not implemented on Windows |
Dear Maintainers,
I am trying to install SVN-Look-0.33 on Windows XP Pro SP3 with
Subversion server 1.7.3 and ActivePerl 5.8.8 build 822 (replica of
company server environment). Using CPAN (see attached cpan.log file),
the SVN-Look tests fail due to the module using a list form of the pipe
open command to capture the output of svnlook commands.
I think that this list form of the pipe open command is not supported
on this version of ActivePerl (tried on latest 5.14.2 as well). In
fact, I think that it may not be supported on Windows at all. I've
attached a patch file which changes the command invocation to the older
style pipe open command which I believe is supported on all platforms.
Please could you take a look.
I would really like to take advantage of both SVN-Look and SVN-Hooks on
our company Subversion server.
Kind Regards,
Mike Brimer
| Subject: | Look.pm.patch |
--- Look.pm.orig Mon Feb 27 23:48:47 2012
+++ Look.pm Mon Mar 05 11:33:45 2012
@@ -14,7 +14,8 @@
BEGIN {
my $path = $ENV{PATH} || '';
- open my $svnlook, '-|', 'svnlook', '--version'
+ my $cmdline = 'svnlook --version';
+ open my $svnlook, "$cmdline |"
or die "Aborting because I couldn't find the 'svnlook' executable in PATH='$path'.\n";
$_ = <$svnlook>;
if (my ($major, $minor, $patch) = (/(\d+)\.(\d+)\.(\d+)/)) {
@@ -43,7 +44,8 @@
my ($self, $cmd, @args) = @_;
my @cmd = ('svnlook', $cmd, $self->{repo});
push @cmd, @{$self->{opts}} unless $cmd =~ /^(?:youngest|uuid|lock)$/;
- open my $fd, '-|', @cmd, @args
+ my $cmdline = "@cmd @args";
+ open my $fd, "$cmdline |"
or die "Can't exec svnlook $cmd: $!\n";
if (wantarray) {
my @lines = <$fd>;
| Subject: | cpan.log |
Message body not shown because it is not plain text.