Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Dist-CheckConflicts CPAN distribution.

Report information
The Basics
Id: 75486
Status: resolved
Priority: 0/
Queue: Dist-CheckConflicts

People
Owner: Nobody in particular
Requestors: ether [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.02
Fixed in: (no value)



Subject: Conflicts not reported when compilation fails
If a -conflicts entry does not compile at all, the conflict is not reported. This is a problem when an installation breaks compatibility severely - e.g. a new requires() entry for a Moose method, or a parent class that changes a dependency for a method modification. A patch is coming up shortly in github.
On Fri Mar 02 12:15:18 2012, ETHER wrote: Show quoted text
> A patch is coming up shortly in github.
This now exists, in https://github.com/karenetheridge/dist-checkconflicts/commits/topic/handle_broken_conflicts -- however it dies on perl5.8.8: perl -Ilib t/02-conflicts.t ok 1 - use Foo::Conflicts::Good; ok 2 - correct versions for all conflicts ok 3 - no conflict error ok 4 - use Foo::Conflicts::Bad; ok 5 - correct runtime warnings for Foo::Conflicts::Bad ok 6 - correct versions for all conflicts ok 7 - correct conflict error ok 8 - use Bar::Conflicts::Good; ok 9 - correct versions for all conflicts ok 10 - no conflict error ok 11 - use Bar::Conflicts::Bad; ok 12 - correct runtime warnings for Bar::Conflicts::Bad ok 13 - correct versions for all conflicts ok 14 - correct conflict error ok 15 - use Foo::Conflicts::Broken; ok 16 - Warning is issued when Broken fails to compile ok 17 - correct versions for all conflicts Warning: Broken did not compile at lib/Dist/CheckConflicts.pm line 273. ok 18 - correct conflict error 1..18 Out of memory! Out of memory! END failed--call queue aborted at t/02-conflicts.t line 157. I have been unable to determine why it happens, but it is inside Module::Runtime::require_module (in the _WORK_AROUND_BROKEN_MODULE_STATE workaround case).
On Fri Mar 02 16:15:17 2012, ETHER wrote: Show quoted text
> On Fri Mar 02 12:15:18 2012, ETHER wrote:
> > A patch is coming up shortly in github.
> > This now exists, in > https://github.com/karenetheridge/dist- > checkconflicts/commits/topic/handle_broken_conflicts
Is there anything I can do to help this issue along? Next week I would like to put up a trial release to 1. get the fix into my production environment which desperately needs it (missing dependencies are being missed because of this problem, leading to misconfigurations), and 2. get some cpantesters reports to help better diagnose the build issue I described.
On 2012-05-12 09:08:15, ETHER wrote: Show quoted text
> On Fri Mar 02 16:15:17 2012, ETHER wrote:
> > On Fri Mar 02 12:15:18 2012, ETHER wrote:
> > > A patch is coming up shortly in github.
> > > > This now exists, in > > https://github.com/karenetheridge/dist- > > checkconflicts/commits/topic/handle_broken_conflicts
> > Is there anything I can do to help this issue along? > > Next week I would like to put up a trial release to 1. get the fix into > my production environment which desperately needs it (missing > dependencies are being missed because of this problem, leading to > misconfigurations), and 2. get some cpantesters reports to help better > diagnose the build issue I described.
Patch is cleaned up in https://github.com/doy/dist-checkconflicts/pull/2. I was unable to reproduce the 5.8.8 issue I reported earlier. I've also released this as 0.006-TRIAL to get some cpantesters reports.
Show quoted text
> I've also released this as 0.006-TRIAL to get some cpantesters > reports.
BTW this pull request is all synced up with the stable release you made in the interim.
This was fixed in 0.07.