| Subject: | txn_root, not revision_root needed in svk_handle method? |
In Kwiki-Archive-SVK-0.03, I am getting immutable file system errors with subversion-1.1.0-RC2, on
Linux momotaro.chinmin.edu.tw 2.4.22-1.2115.nptl #1 Wed Oct 29 15:42:51 EST 2003 i686 i686 i386 GNU/Linux
with perl, v5.8.3 built for i386-linux-thread-multi
See the discussion at http://www.kwiki.org/?SVKProblem
and see the patch in the attachment.
There is also a month problem, 0-11, rather than 1-12, with Time::Local.
--
Greg
--- /usr/local/cpan/5.8.3/build/Kwiki-Archive-SVK-0.03/lib/Kwiki/Archive/SVK.pm 2004-07-28 07:50:04.000000000 +0800
+++ /usr/lib/perl5/site_perl/5.8.3/Kwiki/Archive/SVK.pm 2004-09-02 07:56:01.000000000 +0800
@@ -221,7 +221,7 @@
my $time = shift;
$time =~ /(\d+)-(\d+)-(\d+)T(\d+):(\d+):(\d+)/ or return;
- my $gmtime = timegm($6, $5, $4, $3, $2, $1);
+ my $gmtime = timegm($6, $5, $4, $3, $2-1, $1);
return (
edit_time => scalar gmtime($gmtime),
@@ -294,12 +294,14 @@
# mkdir $subdir if not exists -- refactor back to SVK!
my $fs = ($svk->{xd}->find_repos('//', 1))[2]->fs;
- my $root = $fs->revision_root($fs->youngest_rev);
+ my $txn = $fs->begin_txn($fs->youngest_rev);
+ my $root = $txn->root();
if ($root->check_path("/$subdir") == $SVN::Node::none) {
my $pool = SVN::Pool->new_default;
$root->make_dir("/$subdir", $pool);
$pool->clear;
}
+ my (undef, $rev) = $txn->commit;
$obj->{svk_handle} = $svk;
return $svk;