Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Perl-Critic CPAN distribution.

Report information
The Basics
Id: 75397
Status: resolved
Priority: 0/
Queue: Perl-Critic

People
Owner: Nobody in particular
Requestors: PETDANCE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: (no value)
Fixed in: (no value)



Subject: ProhibitBuiltinHomonyms should include the sub name in the error message
"Subroutine name is a homonym for builtin function" should be "Subroutine name 'whatever' is a homonym for builtin function" so that I don't have to open the source file to know which function it is that is complaining. This is done in Subroutines::ProhibitUnusedPrivateSubroutines like so: "Private subroutine/method '_thpppt' declared but not used"
Subject: Re: [rt.cpan.org #75397] ProhibitBuiltinHomonyms should include the sub name in the error message
Date: Tue, 28 Feb 2012 23:24:30 -0800
To: bug-Perl-Critic [...] rt.cpan.org
From: Jeffrey Thalhammer <jeff [...] imaginative-software.com>
On Feb 28, 2012, at 8:36 PM, Andy Lester via RT wrote: Show quoted text
> "Subroutine name is a homonym for builtin function" > > should be > > "Subroutine name 'whatever' is a homonym for builtin function"
Great suggestion. One of us will do this as soon as we have the tuits. Thanks for the idea. -Jeff
On Wed Feb 29 02:24:41 2012, jeff@imaginative-software.com wrote: Show quoted text
> Great suggestion. One of us will do this as soon as we have the > tuits. Thanks for the idea. > > -Jeff >
I took a swing at it. SVN commit 4121.
This has been completed and released as Perl-Critic-1.118. It looks like we forgot to mention it in the Changes log. Sorry about that.