Bug #75374 for SOAP-Lite: Strings of digits with preceding zeros (e.g. telnums) should be serialized as strings

> See subject. This is to avoid mutilation of data such as telephone > numbers, serial numbers, or any other such string of digits that may > have preceding zero characters. > The regular expression fixes are simple with an added negative > look-ahead for a "0", i.e. (?!0): > > # In custom SOAP child class (if you use one): > sub new { > my $self = shift; > unless(ref($self)) { > $self = $self->SUPER::new(@_); > # ...snip... > my $typelookup = $self->serializer()->typelookup(); > $typelookup->{'int'}->[1] = sub {$_[0] =~ /^(?!0)([+-]?\d{1,10})$/ > && ($1 <= 2147483647) && ($1 >= -2147483648); }; > $typelookup->{'long'}->[1] = sub {$_[0] =~ /^(?!0)([+- > ]?\d{1,19})$/ > && ($1 <= 9223372036854775807); }; > $typelookup->{'float'}->[1] = sub {$_[0] =~ > /^(?!0)(-?(?:\d+(?:\.\d*)?|\.\d+|NaN|INF)|([+- > ]?)(?=\d|\.\d)\d*(\.\d*)?([Ee]([+-]?\d+))?)$/}; > # ...snip... > } > return $self; > }

> See subject. This is to avoid mutilation of data such as telephone > numbers, serial numbers, or any other such string of digits that may > have preceding zero characters. > The regular expression fixes are simple with an added negative > look-ahead for a "0", i.e. (?!0): > > # In custom SOAP child class (if you use one): > sub new { > my $self = shift; > unless(ref($self)) { > $self = $self->SUPER::new(@_); > # ...snip... > my $typelookup = $self->serializer()->typelookup(); > $typelookup->{'int'}->[1] = sub {$_[0] =~ /^(?!0)([+-]?\d{1,10})$/ > && ($1 <= 2147483647) && ($1 >= -2147483648); }; > $typelookup->{'long'}->[1] = sub {$_[0] =~ /^(?!0)([+- > ]?\d{1,19})$/ > && ($1 <= 9223372036854775807); }; > $typelookup->{'float'}->[1] = sub {$_[0] =~ > /^(?!0)(-?(?:\d+(?:\.\d*)?|\.\d+|NaN|INF)|([+- > ]?)(?=\d|\.\d)\d*(\.\d*)?([Ee]([+-]?\d+))?)$/}; > # ...snip... > } > return $self; > }

> Hi, > > this is not a bug, it is by design - a string consisting of digits is > encoded as number by default (which is usually correct, even with > leading zeros - the string "0" usually means the number zero, and for > all fixed-length numerical data preceding zeros are quite normal). > > You can always set $soap->autotype(0) and assign types (in this case: > string) manually. This should always be done for non-uniform data like > telefone numbers. > > Just an example: These three strings can all be (valid) telephone > numbers (depending on their context): > > 12345 > 012312345 > ++49123456789 > > The first and second would (by default) be encoded as number, the third > as string. > > There's no way for SOAP::Lite (as for all computer programs) to > reliably infer the meaning of input data from the data itself. The > encoding SOAP::Lite chooses with autotype on is just an educate guess - > and on not-so-easy-to-guess data like phone numbers, it just guesses > wrong.