Bug #75367 for Moose: attributes with init_arg => undef lose their value after applying a role

Tue Feb 28 04:44:45 2012 abraxxa [...] cpan.org - Ticket created

Subject:

attributes with init_arg => undef lose their value after applying a role

{ package Foo; use Moose; has _read_position => ( init_arg => undef, is => 'ro', ); } { package R; use Moose::Role; } use Test::More; my $i = Foo->new(_read_position => 23); R->meta->apply($i); is $i->_read_position, 23; done_testing;

Mon Mar 12 11:38:37 2012 DOY [...] cpan.org - Correspondence added

Not a bug, attributes with init_arg => undef can't have their values set in the constructor either.

Mon Mar 12 11:38:39 2012 The RT System itself - Status changed from 'new' to 'open'

Mon Mar 12 11:38:40 2012 DOY [...] cpan.org - Status changed from 'open' to 'rejected'

Mon Mar 12 11:45:03 2012 abraxxa [...] cpan.org - Correspondence added

This is the correct test case that matches Catalyst::Request: { package Foo; use Moose; has _read_position => ( init_arg => undef, is => 'ro', writer => '_set_read_position', default => 0, ); } { package R; use Moose::Role; } use Test::More; my $i = Foo->new; $i->_set_read_position(23); R->meta->apply($i); is $i->_read_position, 23; done_testing;

Mon Mar 12 11:45:04 2012 The RT System itself - Status changed from 'rejected' to 'open'

Mon Mar 12 12:16:32 2012 autarch [...] urth.org - Correspondence added

Subject:	Re: [rt.cpan.org #75367] attributes with init_arg => undef lose their value after applying a role
Date:	Mon, 12 Mar 2012 11:16:23 -0500 (CDT)
To:	Jesse Luehrs via RT <bug-Moose [...] rt.cpan.org>
From:	Dave Rolsky <autarch [...] urth.org>

On Mon, 12 Mar 2012, Jesse Luehrs via RT wrote: Show quoted text

> Queue: Moose > Ticket <URL: https://rt.cpan.org/Ticket/Display.html?id=75367 > > > Not a bug, attributes with init_arg => undef can't have their values set > in the constructor either.

This sounds like a bug to me. Applying a role to an object should not change existing attributes in the object. -dave /*============================================================ http://VegGuide.org http://blog.urth.org Your guide to all that's veg House Absolute(ly Pointless) ============================================================*/

Mon Mar 12 12:19:04 2012 doy [...] tozt.net - Correspondence added

Subject:	Re: [rt.cpan.org #75367] attributes with init_arg => undef lose their value after applying a role
Date:	Mon, 12 Mar 2012 11:18:56 -0500
To:	"autarch [...] urth.org via RT" <bug-Moose [...] rt.cpan.org>
From:	Jesse Luehrs <doy [...] tozt.net>

Yes, the second test that was provided does demonstrate a bug (in the first test, the attribute never had a value, because init_arg was undef and the value was provided in the constructor). This is probably an issue with the attribute value fixups we do in rebless_instance.

Fri Aug 10 12:07:00 2012 aduitsis [...] gmail.com - Ticket #78893: Ticket created

Subject:	applying role resets attributes with default and init_arg=>undef
Date:	Fri, 10 Aug 2012 19:06:50 +0300
To:	bug-moose [...] rt.cpan.org
From:	Athanasios Douitsis <aduitsis [...] gmail.com>

Hi, I don't know whether this is a bug or normal behavior, but here goes: Say I have a role (ROLE1) that has an attribute with a default value (default=>'') and init_arg=>undef. I apply this role as usual with ROLE1->meta->apply( $object ), then set the attribute to a value normally. If later in my program I have to apply another role (say ROLE2) to the same object, the attribute from ROLE1 will be reset again to ''. Removing the init_arg or the default from the attribute stops this phenomenon. Is this normal? Thanks very much in advance and keep up the good work! ... -- Athanasios Douitsis

Fri Aug 10 12:11:23 2012 DOY [...] cpan.org - Ticket #78893: Merged into ticket #75367

Fri Aug 10 12:11:23 2012 DOY [...] cpan.org - Merged into ticket #75367