Bug #75273 for Dist-Zilla-Plugin-ReadmeFromPod: should be FileGatherer, not InstallTool

Fri Feb 24 08:06:27 2012 rjbs [...] cpan.org - Ticket created

Subject:

should be FileGatherer, not InstallTool

Probably it's an InstallTool for ordering reasons. These won't be relevant if it produces a FromCode file instead of a InMemory file. -- rjbs

Fri Feb 24 22:18:01 2012 fayland [...] cpan.org - Correspondence added

I applied the patch from RT 75272. but this error is very annoying [DZ] attempt to add README multiple times; added by: @Filter/Readme (Dist::Zilla::Plugin::Readme line 39); ReadmeFromPod (Dist::Zilla::Plugin::ReadmeFromPod line 67) aborting; duplicate files would be produced at /Users/fayland/perl5/lib/perl5/Dist/Zilla/App/Command/test.pm line 27 that we need use [@Filter] remove = Readme [ReadmeFromPod] to fix. but I think the people who use ReadmeFromPod will have "discard Readme" in his mind. how about write some code to do it by default? Thanks

Fri Feb 24 22:18:03 2012 The RT System itself - Status changed from 'new' to 'open'

Fri Feb 24 22:18:03 2012 fayland [...] cpan.org - Status changed from 'open' to 'resolved'

Fri Feb 24 23:09:19 2012 fayland [...] cpan.org - Correspondence added

at last I still roll it back to InstallTool because the POD must be after PodWeaver. Thanks

Fri Feb 24 23:09:20 2012 The RT System itself - Status changed from 'resolved' to 'open'

Fri Feb 24 23:11:05 2012 rjbs [...] cpan.org - Correspondence added

On 2012-02-24 23:09:19, FAYLAND wrote: Show quoted text

> at last I still roll it back to InstallTool > > because the POD must be after PodWeaver.

If the file created is a File::FromCode, then the content is not generated until read. That means that it will not be generated until written to disk during the final moments of build. By that point, FileMunging is done. That is exactly why FromCode files exist. Using InstallTool is not necessary. -- rjbs

Fri Feb 24 23:53:48 2012 fayland [...] cpan.org - Correspondence added

but I want to avoid [DZ] attempt to add README multiple times; added by: @Filter/Readme (Dist::Zilla::Plugin::Readme line 39); ReadmeFromPod (Dist::Zilla::Plugin::ReadmeFromPod line 67) aborting; duplicate files would be produced at /Users/fayland/perl5/lib/perl5/Dist/Zilla/App/Command/test.pm line 27 and I don't want to add remove = Readme is there a way to do it? Thanks.

Sat Feb 25 00:00:53 2012 rjbs [...] cpan.org - Correspondence added

On 2012-02-24 23:53:48, FAYLAND wrote: Show quoted text

> but I want to avoid > > [DZ] attempt to add README multiple times; added by: @Filter/Readme > (Dist::Zilla::Plugin::Readme line 39); ReadmeFromPod > (Dist::Zilla::Plugin::ReadmeFromPod line 67) > aborting; duplicate files would be produced at > /Users/fayland/perl5/lib/perl5/Dist/Zilla/App/Command/test.pm line 27 > > and I don't want to add > > remove = Readme > > is there a way to do it?

Every other FileGatherer plugin lives by the "just add the file; the user has to keep track of not adding more than one." I think it is not a great idea to silently throw away other README files. It will hide misconfiguration. It also means that your plugin is not acting like most other plugins that do similar jobs. Anyway: No, you can't easily avoid the rule above if you are just a FileGatherer. While you could remove any README file you find when running, it wouldn't be effective if the other README is added after you. (In practice, most users will have [ReadmeFromPod] later than [GatherDir], but not all.) Going to bed now. Good night! -- rjbs

Tue Nov 26 08:02:27 2013 ether [...] cpan.org - Correspondence added

Looks like this dist is still using InstallTool? I has sad panda.

Thu Jul 06 22:36:53 2017 PERLANCAR [...] cpan.org - Correspondence added

On Sat, 25 Feb 2012 04:09:19 GMT, FAYLAND wrote: Show quoted text

> at last I still roll it back to InstallTool > > because the POD must be after PodWeaver. > > Thanks

BTW, isn't ordering supposed to be done by the order we specify the plugins in dist.ini (or PluginBundle)?