Bug #75257 for XML-LibXML: overloading 'eq'/'==' for XML::LibXML::Element

Thu Feb 23 18:31:02 2012 perl [...] toby.ink - Ticket created

In much of my code I do things like: if ($element1 == $element2) { ... } Overloading hash deref seems to have broken this approach. It's not clear that this was ever officially supported - there's no test case for it - but it seemed to work. Now it doesn't. Mea culpa. Anyway, this fixes it: package XML::LibXML::Element; use Scalar::Util qw/blessed/; use overload 'eq' => '_isSameNodeLax', '==' => '_isSameNodeLax'; sub _isSameNodeLax { my ($self, $other) = @_; if (UNIVERSAL::can($other, 'isa') and $other->isa('XML::LibXML::Element')) { return $self->isSameNode($other); } return; }

Thu Feb 23 18:39:36 2012 perl [...] toby.ink - Subject changed from (no value) to 'overloading 'eq'/'==' for XML::LibXML::Element'

Mon Feb 27 03:54:28 2012 SHLOMIF [...] cpan.org - Correspondence added

Hi Toby, On Thu Feb 23 18:31:02 2012, TOBYINK wrote: Show quoted text

> In much of my code I do things like: > > if ($element1 == $element2) { > ... > } > > Overloading hash deref seems to have broken this approach. It's not > clear that this was ever officially supported - there's no test case > for it - but it seemed to work. Now it doesn't. Mea culpa. > > Anyway, this fixes it: > > package XML::LibXML::Element; > use Scalar::Util qw/blessed/; > use overload 'eq' => '_isSameNodeLax', '==' => '_isSameNodeLax'; > sub _isSameNodeLax > { > my ($self, $other) = @_; > if (UNIVERSAL::can($other, 'isa') > and $other->isa('XML::LibXML::Element')) > { > return $self->isSameNode($other); > } > return; > }

That seems fair. Can you provide a pull request for this, which will include some trivial tests? I also think that using UNIVERSAL::can is discouraged, and you should use blessed() instead. Moreover "==" and "eq" return the empty string, including in list context: $ perl -E '@x=((5 == 6), 7); use Data::Dumper; print Dumper(\@x)' $VAR1 = [ '', 7 ]; Regards, -- Shlomi Fish

Mon Feb 27 03:54:30 2012 The RT System itself - Status changed from 'new' to 'open'

Mon Feb 27 04:20:30 2012 SHLOMIF [...] cpan.org - Correspondence added

OK, I already fixed it myself with some added tests, so I'm resolving this bug. Thanks for the report and for the partial patch (which I had to modify).

Mon Feb 27 04:20:31 2012 SHLOMIF [...] cpan.org - Status changed from 'open' to 'resolved'