Skip Menu |

This queue is for tickets about the Digest-SHA CPAN distribution.

Report information
The Basics
Id: 75239
Status: resolved
Worked: 15 min
Priority: 0/
Queue: Digest-SHA
People
Owner: mshelor [...] cpan.org
Requestors: zefram [...] fysh.org
Cc:
AdminCc:
Bug Information
Severity: Normal
Broken in: 5.70
Fixed in: 5.71

History Show all quoted text
  Thu Feb 23 06:01:56 2012 zefram [...] fysh.org - Ticket created
Subject: $! gets lost when croaking
Date: Thu, 23 Feb 2012 11:01:43 +0000
To: bug-Digest-SHA [...] rt.cpan.org
From: Zefram <zefram [...] fysh.org>
When Digest::SHA croaks due to an I/O error, it helpfully tries to include $! in the error message. However, it does a "require Carp" before looking at $!, and if Carp wasn't already loaded then this will perform file I/O that overwrites $!. This leads to getting an incorrect error message. Attached patch fixes. -zefram

Message body is not shown because sender requested not to inline it.

  Thu Feb 23 18:29:33 2012 mshelor [...] cpan.org - Taken
  Thu Feb 23 18:34:36 2012 mshelor [...] cpan.org - Correspondence added
Yes, you are quite correct. Thanks for the patch. I'll include the fix with version 5.71, to appear in the next week or so. Mark
  Thu Feb 23 18:34:37 2012 The RT System itself - Status changed from 'new' to 'open'
  Wed Feb 29 21:03:19 2012 mshelor [...] cpan.org - Correspondence added 15 min
Fixed, as of 5.71, in Digest::SHA and Digest::SHA::PurePerl.
  Wed Feb 29 21:03:20 2012 mshelor [...] cpan.org - Status changed from 'open' to 'resolved'
  Wed Feb 29 21:05:31 2012 mshelor [...] cpan.org - Fixed in 5.71 added
  Wed Feb 29 21:05:31 2012 mshelor [...] cpan.org - Severity Normal added
  Wed Feb 29 21:05:31 2012 mshelor [...] cpan.org - Broken in 5.70 added