Bug #75209 for MooX-Types-MooseLike: [PATCH] Import 'Exporter' directly without using 'base'

Wed Feb 22 07:58:49 2012 dolmen [...] cpan.org - Ticket created

Subject:

Import 'Exporter' directly without using 'base'

In 0.02, the Exporter module is imported with the following line: use base 'Exporter'; This does not matches the documented way of loading Exporter (see https://metacpan.org/module/Exporter#SYNOPSIS ) and it makes use of base.pm while this could be cleanly avoided. Suggested patch: - use base 'Exporter'; + use Exporter 5.57 'import'; Advantages: - one less module loaded (base.pm), less code compiled/processed - avoids to load base.pm (an old module which is better replaced by parent.pm for the most common use case) - avoids to depend on base.pm for this distribution (META.yml) -- Olivier Mengué - http://perlresume.org/DOLMEN

Sat Feb 25 05:55:35 2012 dolmen [...] cpan.org - Correspondence added

Subject:	[PATCH] Import 'Exporter' directly without using 'base'
RT-Send-CC:	mateu [...] cpan.org

Hi, Here is a patch: https://github.com/mateu/MooX-Types-MooseLike/pull/2 Le 2012-02-22 13:58:49, DOLMEN a écrit : Show quoted text

> In 0.02, the Exporter module is imported with the following line: > use base 'Exporter'; > > This does not matches the documented way of loading Exporter (see > https://metacpan.org/module/Exporter#SYNOPSIS ) and it makes use of > base.pm while this could be cleanly avoided. > > Suggested patch: > - use base 'Exporter'; > + use Exporter 5.57 'import';

-- Olivier Mengué - http://perlresume.org/DOLMEN

Sat Feb 25 05:55:37 2012 dolmen [...] cpan.org - Status changed from 'new' to 'open'

Sat Feb 25 05:56:08 2012 dolmen [...] cpan.org - Subject changed from 'Import 'Exporter' directly without using 'base'' to '[PATCH] Import 'Exporter' directly without using 'base''

Mon Mar 19 12:45:22 2012 MATEU [...] cpan.org - Correspondence added

Thanks for the suggestion

Mon Mar 19 12:45:23 2012 MATEU [...] cpan.org - Status changed from 'open' to 'resolved'