Skip Menu |

This queue is for tickets about the Catalyst-Runtime CPAN distribution.

Report information
The Basics
Id: 75139
Status: resolved
Priority: 0/
Queue: Catalyst-Runtime

People
Owner: Nobody in particular
Requestors: DOUGDUDE [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: 5.90010
Fixed in: (no value)



Subject: Test failure on Windows
There is a test failure in t/aggregate/unit_utils_home.t due to checking the output of Path::Class::path against the output of Cwd::cwd (because path is setting the path separators to "/" but cwd keeps the original OS path separators of "\"). I've attached a patch for the test, which brings the test in line with the other two tests in the file, in that the path is compared to path($p)->absolute->cleanup. On Windows, this changes the "\" in cwd() to "/" so that it matches that from Catalyst::Utils::find_home_unloaded_in_checkout().
Subject: 0001-Cleanup-cwd-output-in-test.patch
From 9c8aeae74ce5da7dfa7e226aeb60bfd6faac4b62 Mon Sep 17 00:00:00 2001 From: Douglas Christopher Wilson <doug@somethingdoug.com> Date: Sun, 19 Feb 2012 15:52:12 -0500 Subject: [PATCH] Cleanup cwd() output in test. --- t/aggregate/unit_utils_home.t | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/t/aggregate/unit_utils_home.t b/t/aggregate/unit_utils_home.t index 587f618..c5e82fa 100644 --- a/t/aggregate/unit_utils_home.t +++ b/t/aggregate/unit_utils_home.t @@ -36,7 +36,7 @@ foreach my $inc ('', 'lib', 'blib'){ ok !Catalyst::Utils::find_home_unloaded_in_checkout(); open(my $fh, '>', "Makefile.PL"); close($fh); - is Catalyst::Utils::find_home_unloaded_in_checkout(), cwd(), "Did find home_unloaded_in_checkout" + is Catalyst::Utils::find_home_unloaded_in_checkout(), dir(cwd())->absolute->cleanup, "Did find home_unloaded_in_checkout" } chdir($cwd); -- 1.7.6.msysgit.0
On Sun Feb 19 15:53:01 2012, DOUGDUDE wrote: Show quoted text
> There is a test failure in t/aggregate/unit_utils_home.t due to checking > the output of Path::Class::path against the output of Cwd::cwd (because > path is setting the path separators to "/" but cwd keeps the original OS > path separators of "\"). > > I've attached a patch for the test, which brings the test in line with > the other two tests in the file, in that the path is compared to > path($p)->absolute->cleanup. On Windows, this changes the "\" in cwd() > to "/" so that it matches that from > Catalyst::Utils::find_home_unloaded_in_checkout().
I'm going to reply to this as resolved, as commit a8946dc8b4ba4c46b4db564b8f9692d48cc7a62f removed the test in question.