Skip Menu |

This queue is for tickets about the Unicode-EastAsianWidth CPAN distribution.

Report information
The Basics
Id: 75132
Status: resolved
Priority: 0/
Queue: Unicode-EastAsianWidth

People
Owner: Nobody in particular
Requestors: ANDK [...] cpan.org
Cc: public [...] khwilliamson.com
AdminCc:

Bug Information
Severity: Normal
Broken in: 1.30
Fixed in: (no value)



CC: public [...] khwilliamson.com
Subject: Fails since bleadperl v5.15.6-494-gdc415b4
As per subject. Git bisect reports: dc415b4a4cd50c68d6d3216ef105f1cbc2e2e266 is the first bad commit commit dc415b4a4cd50c68d6d3216ef105f1cbc2e2e266 Author: Karl Williamson <public@khwilliamson.com> Date: Mon Nov 28 10:26:28 2011 -0700 Move Unicode property defn processing to compile time CC'd to Karl, Kind regards,
I see still failures with perl 5.16.0 RC0. Regards, Slaven
CC: ANDK [...] cpan.org
Subject: Re: [rt.cpan.org #75132] Fails since bleadperl v5.15.6-494-gdc415b4
Date: Sat, 12 May 2012 07:47:28 -0600
To: bug-Unicode-EastAsianWidth [...] rt.cpan.org
From: Karl Williamson <public [...] khwilliamson.com>
On 05/12/2012 01:46 AM, Slaven_Rezic via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=75132> > > I see still failures with perl 5.16.0 RC0. > > Regards, > Slaven > >
This is the first I've heard of this failure. I will look at it now.
CC: ANDK [...] cpan.org, Ricardo Signes <rjbs [...] manxome.org>
Subject: Re: [rt.cpan.org #75132] Fails since bleadperl v5.15.6-494-gdc415b4
Date: Sat, 12 May 2012 08:39:27 -0600
To: bug-Unicode-EastAsianWidth [...] rt.cpan.org
From: Karl Williamson <public [...] khwilliamson.com>
(adding rjbs to cc: as a heads-up for him) On 05/12/2012 01:46 AM, Slaven_Rezic via RT wrote: Show quoted text
> <URL: https://rt.cpan.org/Ticket/Display.html?id=75132> > > I see still failures with perl 5.16.0 RC0. > > Regards, > Slaven > >
(I've done some further checking, and don't see any evidence that I received the email that Andreas sent to me about this, so it appears that the email gods lost it.) This appears to be a bug in the module. The failing test is attempting to change the behavior of the user-defined property at run time. The documentation for it says, Setting C<$Unicode::EastAsianWidth::EastAsian> at run-time only works on Perl version 5.8 or above. Perl 5.6 users must use a BEGIN block to set it before the C<use> statement: BEGIN { $Unicode::EastAsianWidth::EastAsian = 1 } use Unicode::EastAsianWidth; And, indeed the failing test is only done for those newer Perls. However, it only worked through an accident of the implementation; it was never supposed to work. perlunicode.pod explicitly says (from its blame log): bac0b425 (Jeff Pinyan 2004-04-14 13:01:38 -0400 824) Note that the effect is compile-time and immutable once defined. "824)" means this text is on line 824 of the current blead. The date of that commit is apparently for 5.8.3. I didn't bother to see what we said before that commit. So, I don't know what to do. I could fix things so user-defined properties are never determined at compile-time, which would revert to the old behavior, which differs from the long-standing core documentation. Doing so would require getting approval on p5p. Or, the module could change its documentation to say that the run-time changeable behavior stops at 5.14, and change its test accordingly. That would affect its users.
On Sat May 12 10:39:44 2012, public@khwilliamson.com wrote: Show quoted text
> (adding rjbs to cc: as a heads-up for him) > > On 05/12/2012 01:46 AM, Slaven_Rezic via RT wrote:
> > <URL: https://rt.cpan.org/Ticket/Display.html?id=75132> > > > > I see still failures with perl 5.16.0 RC0. > > > > Regards, > > Slaven > > > >
> > (I've done some further checking, and don't see any evidence that I > received the email that Andreas sent to me about this, so it appears > that the email gods lost it.)
I’ve noticed that, too. I think the cc field in the web interface for creating a ticket just adds that e-mail address to the cc list for future ticket updates, without forwarding the ticket’s first message immediately.
When things boil down to "should not have worked and was documented not to work," my preference is to let them stop actually working. Audrey, can you give us any idea how big of a deal this is going to be downstream? -- rjbs
On Sat May 12 21:26:40 2012, RJBS wrote: Show quoted text
> When things boil down to "should not have worked and was documented > not to work," my preference is to let them stop actually working.
Concurred. Show quoted text
> Audrey, can you give us any idea how big of a deal this is going to be > downstream?
Not much, and I think it's reasonable to mandate setting the flag in BEGIN block. Unicode-EastAsianWidth 1.31 will hit CPAN today with an updated POD and test that works on 5.16.0. Cheers, Audrey