Skip Menu |

Preferred bug tracker

Please visit the preferred bug tracker to report your issue.

This queue is for tickets about the Mail-Sender CPAN distribution.

Report information
The Basics
Id: 75109
Status: resolved
Priority: 0/
Queue: Mail-Sender

People
Owner: JENDA [...] cpan.org
Requestors: TODDR [...] cpan.org
Cc:
AdminCc:

Bug Information
Severity: Normal
Broken in: 0.8.16
Fixed in: (no value)



Subject: defined @array deprecated since perl 5.6
Hi, in perl 5.16, perl will emit warnings if defined @array is used. defined @array has been deprecated since perl 5.5 and now will emit an official warning in 5.15.7. It turns out that defined @array probably doesn't do what you want anyways: defined(@array) changes depending on if the array has EVER been of non-zero size
Patch is attached to correct the problem
Subject: Mail-Sender.patch.txt
commit b8281c8655ebe173abeb36da6382016abf957634 Author: Todd Rinaldo <toddr@cpan.org> Date: Sat Feb 18 01:07:32 2012 -0600 RT 75109 - remove defined @array checks for Mail::Sender diff --git a/Sender.pm b/Sender.pm index 6fe1aba..d7169a5 100644 --- a/Sender.pm +++ b/Sender.pm @@ -315,7 +315,7 @@ my $debug_code; sub __Debug { my ($socket, $file) = @_; if (defined $file) { - unless (defined @Mail::Sender::DBIO::ISA) { + unless (@Mail::Sender::DBIO::ISA) { eval "use Symbol;"; eval $debug_code; die $@ if $@; @@ -2690,7 +2690,7 @@ You should NOT touch the $sender->{'socket'} unless you really really know what package Mail::Sender; sub GetHandle { my $self = shift(); - unless (defined @Mail::Sender::IO::ISA) { + unless (@Mail::Sender::IO::ISA) { eval "use Symbol;"; eval $pseudo_handle_code; }
In 0.8.22