Skip Menu |

This queue is for tickets about the TeX-Hyphen CPAN distribution.

Report information
The Basics
Id: 75088
Status: resolved
Priority: 0/
Queue: TeX-Hyphen

People
Owner: Nobody in particular
Requestors: somloieater [...] gmail.com
Cc:
AdminCc:

Bug Information
Severity: (no value)
Broken in: (no value)
Fixed in: 1.15



Subject: TeX-Hyphen-1.01 rightmin not obeyed, utf8 handling
Date: Fri, 17 Feb 2012 11:56:34 +0200
To: bug-TeX-Hyphen [...] rt.cpan.org
From: David Gardner <somloieater [...] gmail.com>
Hi, I attach a patch for TeX-Hyphen-1.01 which solves the following issues: 1. in hyphenate() the default value of ($RIGHTMIN) was used when checking for patterns, but hyphenation was permitted using user-supplied $self->{rightmin}. This allowed illegal breaks if $RIGHTMIN<$self{rightmin}. 2. TeX-Hyphen/czech.pm assumes latin1 input. I provide a cut-down version for utf8 data, with correct setting of binmode (only) if this is selected. 3. From the debugging info the difference between end patterns and general patterns e.g. "2n." and "1n" was lost. I have added dots to help identify which type of pattern is being applied.

Message body is not shown because sender requested not to inline it.

On Fri, 17 Feb 2012 09:56:45 GMT, somloieater@gmail.com wrote: Show quoted text
> Hi, > I attach a patch for TeX-Hyphen-1.01 which solves the following issues: > > 1. in hyphenate() the default value of ($RIGHTMIN) was used when > checking for patterns, but hyphenation was permitted using > user-supplied $self->{rightmin}. This allowed illegal breaks if > $RIGHTMIN<$self{rightmin}.
I don't think illegal breaks could occur because we clear the breakpoint beyond the right limit at the end. But it sure is faster not to try to find them at all. Show quoted text
> 2. TeX-Hyphen/czech.pm assumes latin1 input. I provide a cut-down > version for utf8 data, > with correct setting of binmode (only) if this is selected. > > 3. From the debugging info the difference between end patterns and > general patterns > e.g. "2n." and "1n" was lost. I have added dots to help identify which > type of pattern is > being applied.
Merged. Released as 1.15. Sorry it took me so long to respond.