Skip Menu |

This queue is for tickets about the Socket CPAN distribution.

Report information
The Basics
Id: 75074
Status: resolved
Priority: 0/
Queue: Socket
People
Owner: Nobody in particular
Requestors: leonerd-cpan [...] leonerd.org.uk
Cc:
AdminCc:
Bug Information
Severity: (no value)
Broken in: 1.98
Fixed in:
  • 1.98_001
  • 1.99

History Show all quoted text
  Thu Feb 16 17:52:28 2012 leonerd-cpan [...] leonerd.org.uk - Ticket created
Subject: inet_pton() returns overly-long result for AF_INET
$ perl -MSocket=AF_INET,inet_pton -E 'say length inet_pton( AF_INET, "127.0.0.1" )' 16 $ perl -MSocket=inet_aton -E 'say length inet_aton( "127.0.0.1" )' 4 -- Paul Evans
  Thu Feb 16 18:34:52 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added
Attached is a patch to fix it. Will be in 1.99 along with some more robust testing that would have detected this one. -- Paul Evans
Subject: rt75074.patch
=== modified file 'Socket.xs' --- Socket.xs 2012-02-12 11:37:51 +0000 +++ Socket.xs 2012-02-16 23:33:47 +0000 @@ -912,17 +912,23 @@ CODE: #ifdef HAS_INETPTON int ok; + int addrlen = 0; #ifdef AF_INET6 struct in6_addr ip_address; #else struct in_addr ip_address; #endif - if (af != AF_INET + switch(af) { + case AF_INET: + addrlen = 4; + break; #ifdef AF_INET6 - && af != AF_INET6 + case AF_INET6: + addrlen = 16; + break; #endif - ) { + default: croak("Bad address family for %s, got %d, should be" #ifdef AF_INET6 " either AF_INET or AF_INET6", @@ -935,7 +941,7 @@ ST(0) = sv_newmortal(); if (ok) { - sv_setpvn( ST(0), (char *)&ip_address, sizeof(ip_address) ); + sv_setpvn( ST(0), (char *)&ip_address, addrlen); } #else ST(0) = (SV*)not_here("inet_pton");
  Thu Feb 16 18:34:53 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'new' to 'patched'
  Thu Feb 16 19:24:44 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added
On Thu Feb 16 18:34:52 2012, PEVANS wrote: Show quoted text
> Attached is a patch to fix it. > > Will be in 1.99 along with some more robust testing that would have > detected this one.
Now CPANned as 1.98_001. -- Paul Evans
  Thu Feb 16 19:24:46 2012 The RT System itself - Status changed from 'patched' to 'open'
  Wed Feb 22 06:47:12 2012 leonerd-cpan [...] leonerd.org.uk - Correspondence added
Released as 1.99 -- Paul Evans
  Wed Feb 22 06:47:13 2012 leonerd-cpan [...] leonerd.org.uk - Status changed from 'open' to 'resolved'
  Wed Feb 22 06:47:23 2012 leonerd-cpan [...] leonerd.org.uk - Fixed in 1.98_001 added
  Wed Feb 22 06:47:23 2012 leonerd-cpan [...] leonerd.org.uk - Fixed in 1.99 added